Page MenuHomePhabricator

PlanarFigure is not in correct state after editing
Closed, ResolvedPublic

Description

When clicking onto a control-point of a planarFigure AND have a rather time-consuming operation connected to the EndInteractionPlanarFigureEvent() AND move your cursor out of the RenderWindow while this operation is done, the planarFigure is not in correct state after the operation is finished.

This is because the statemachine checks the hovering after deselcting the control-point. However, the event that is used here still has the same coordinates -> is still above the control-point.

Instead, the control-points should be deselected, when a new mousemove event comes, everything is fine again.

Event Timeline

Fix has been implemented as proposed and merged into master

added core-modification wiki page..

[34e918]: Merge branch 'bug-11465-planarfigure-state'

Merged commits:

2012-03-28 16:18:13 Markus Engel [3b7c1e]
corrected planarFigureInteractor & statemachine

REVIEW: The implemented solution removes the hover-effect of PlanarFigure control points after clicking on a control point. When the mouse is moved outside of the control point area, no false hover effect is shown anymore.

As a consequence, hover is also (temporarily) disabled when clicking on a control point and not moving the mouse at all. Only when the mouse is moved again while still being over the control point, hover is again turned on. This effect however seems negligible and shouldn't be noticeable in normal user interactions.

Implementation is simple and straightforward.