Page MenuHomePhabricator

PlanarFigure Nodes created by MeasurementView are not added to Datastorage
Closed, ResolvedPublic

Event Timeline

To reproduce:

Load image
Draw planarfigure using measurement
Switch to pvanalysis
draw planarfigure using pvanalysis
switch to measurement
Draw planarfigure using measurement

The last one will not be visible in the datamanager.

For a start, measurements DetectTopMostVisibleImage() method will find two images on the second try.

Toggling the visibility of helper objects will yield the image Clusterprobs. Drawing planar figures using the measurement plugin, while having helper objects visible, the new images will be added to the datastorage as children of the Clusterprobs image.

This could probably be fixed by having DetectTopMostVisibleImage() check, whether said image is a helper node and not adding to those.

Personally, I would suggest to:

  1. Check if an image is selected a. if yes, add planarfigure to said image b. if no, search for the topmost non-helper node image, add planarfigure to that one

Added few lines to avoid selecting the image stored as helper node as parent for the measurement.

Also added a prefix to the PartialVolumeAnalysisView to distinguish the planar figures created there from the figures created by the measurement toolbox.

I can not find a pushed branch of this. Jan do you have it locally?