Page MenuHomePhabricator

Undo/redo stack should not save all render window interactions
Closed, ResolvedPublic

Description

like zooming or translations -> stack is full pretty fast and more "undo/redo worthy" operations like changes to a segmentation are dropped.

Event Timeline

On Windows 7 installations, if you zoom and undo, then an unproper behaviour occurs, i.e. the window doesn't zoom out but somehow shrinks the image and glues it into the corner of the window. This process can be reversed by the redo operation.

MITK-1-0 keyword is obsolete, we use Target Milestones in the future.

I removed the parts where interactions on the render windows are added to the stack (m_UndoController) of undo operations. Undo operations on the segmentation bundle work as before. However, I have now overview of other Modules that use Undo-Redo, so this should be tested before the release

Changes look fine for me. However Thomas could you clean up the changes in the mitkDisplayVectorInteractor? There are two sections where the undo stuff is just uncommented. These parts can be completely removed.

cleaned up the code as requested.
wrote core modification spec in wiki

bug-12053-NoUndoOfWindowInteractions is the important branch

[bc4642]: Merge branch 'bug-12053-NoUndoOfWindowInteractions'

Merged commits:

2012-06-11 11:43:12 Thomas Van Bruggen [8bc318]
clean up


2012-06-08 09:47:23 Thomas Van Bruggen [dd87b5]
remove additions of rendenderwindow interactions to the undo stack