Page MenuHomePhabricator

DisplayVectorInteractorScroll checks buttonstate internally
Closed, ResolvedPublic

Description

The DisplayVectorInteractorScroll internally checks the button state of the event to determine whether the ALT modifier key has been pressed. Depending on the state, a bool flag is set.

This is bad, as the listener should never check button states (or similar) to determine it's internal state. This logic should be 'implemented' using the actual statemaching pattern.

Event Timeline

[1554ee]: Merge branch 'bug-12404-scroll-listener-button-state-2'

Merged commits:

2012-07-04 14:28:08 Markus Engel [e134d9]
using additional actions to determine logic instead of button state