Page MenuHomePhabricator
Create Task
Maniphest T12407

Clean up includes of MITK core
Closed, WontfixPublic
Actions

Description

Check if all includes are necessary. Some can be moved from the cpp to the header file, some may even be removed completely.

Marco created a list of candidates of unnecessary header includes of MITK core, which I'll add as attachment to this bug.

Related Objects

Event Timeline

franza added projects: MITK, Bugzilla.Jul 4 2012, 3:48 PM
franza added a subscriber: franza.

List of candidates with unnecessary header includes

20120620_mitk-includes_vonMarco.txt61 KBDownload

franza added a comment.Oct 22 2014, 3:41 PM

Maybe the list is a bit out of date. But cleaning up the includes still might help to improve the build time.

maerz added a subscriber: maerz.Jul 15 2015, 4:45 PM

I'll start working on this periodically as filler when I have no task towards the end of bugsquashing

maerz added a comment.Jul 15 2015, 4:50 PM

To Facialiate work on this, I moved the List to google docs. Anyone can participate! Yay!

Also I request a core flag pre-emptively as only headers will be touched and I would like to steadly merge the changes back into mitk.

• git-user added a subscriber: • git-user.Jul 15 2015, 4:58 PM

User maerz has pushed new remote branch:

bug-12407-CleanupIncludesOfMITKCore
nolden added a subscriber: nolden.Jul 20 2015, 10:25 AM

I think the availability of useful tools is better than it was at the time we "started" working on this:

http://include-what-you-use.org/

I have some experience with clang based tools, Caspar as well, so maybe we should look at it together.

And there is also something integrated in Eclipse CDT, forgot the name, but easy to find.

zelzer added a subscriber: zelzer.Jul 20 2015, 6:42 PM

CMake 3.3 will support running IWYU along side with the usual compiler for Makefile and Ninja generators:

http://www.cmake.org/cmake/help/v3.3/prop_tgt/LANG_INCLUDE_WHAT_YOU_USE.html#prop_tgt:%3CLANG%3E_INCLUDE_WHAT_YOU_USE

maerz added a comment.Jun 29 2016, 2:36 PM

stopped working on this, as other automatic approaches are more favorable.

kislinsk edited projects, added MITK (2016-11); removed MITK.Aug 1 2016, 10:48 PM
kislinsk edited projects, added MITK; removed MITK (2016-11).Feb 6 2017, 11:24 AM
hentsch mentioned this in T23755: Clean up includes.Nov 17 2017, 12:10 PM
kislinsk mentioned this in T27033: Clean up stale remote branches.Jan 25 2020, 9:01 PM
kislinsk closed this task as Wontfix.Apr 29 2022, 1:44 PM
kislinsk added a project: Auto-closed.
kislinsk added a subscriber: kislinsk.

Hi there! 🙂

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. 🚑

Best wishes,
The MITK devs

MITK · MIC · IMSY · DKFZ