Page MenuHomePhabricator

[Dashboard] MITK log test fails randomly on dart clients
Closed, ResolvedPublic

Description

The MITK log test fails randomly on dart clients a possible reason is that the test uses a delay to wait for threads to end. Maybe it's better to use a method to wait and ensure that the thread truly ended.

Event Timeline

[f275c4]: Merge branch 'bug-12910-MITKLogTestWaitForThreadsAndTerminate'

Merged commits:

2012-08-22 14:27:22 Christoph Kolb [064a89]
Call of method to wait for threads to end added


2012-08-15 15:37:47 Christoph Kolb [7bf605]
Fix 3 typing errors in MITK concepts (doxygen)

accidently pushed the fix for T12236 :

2012-08-15 15:37:47 Christoph Kolb [7bf605]
Fix 3 typing errors in MITK concepts (doxygen)

Reopened bug, because test still fails randomly on nightly dart clients as well as on continuous dart clients.

Example:
http://cdash.mitk.org/testDetails.php?test=3670916&build=179472

[cfa09a]: Merge branch 'bug-12910-MITKLogTestWaitForThreadsAndTerminate'

Merged commits:

2012-09-12 15:45:39 Alfred Franz [5ff74b]
added smart pointers for test objects, so the objects are not deleted when out of focus before the thread is ended

Test still fails randomly. It seems that in some cases the test ends before all threads are terminated and this causes errors. An example:
http://mbits/cdash/testDetails.php?test=2805777&build=145469

The relevant test output:

!0.260! WARNING: Test warning stream in thread 2
#0.260# ERROR: Test error stream in thread 1
#0.260# ERROR: Test error stream in thread 2
*0.260* FATAL: Test fatal stream in thread 1
*0.260* FATAL: Test fatal stream in thread 2
Test logging in different threads. [PASSED]
[0.260] Logfile: /home/zelzer/.mitk/testlog.log
[0.260] Test logging to default filename: /home/zelzer/.mitk/testlog.log
Testing if log file exists. [PASSED]
[0.260] Test logging
[0.260] Test logging
Test add/remove logging backend. [PASSED]
"Log": 5 tests [DONE PASSED]
[0.260] closing logfile (/home/zelzer/.mitk/testlog.log)
[0.260] Test info stream in thread 1

The last line is the error. A test message is written although the test already ended.

[4fccf4]: Merge branch 'bug-12910-MITKLogTestWaitForThreadsAndTerminate'

Merged commits:

2012-10-31 13:39:28 Christoph Kolb [764c6f]
COMP: save the threadIDs of spawned threads in order to terminate them properly

I assume this bug is fixed now. If there is now random fail within one week we can close it.

didn't fail last week, so closing the bug