Page MenuHomePhabricator

Improve segmentation selection behavior regarding usability
Closed, ResolvedPublic


At the moment the data node selection behavior is rather nasty and cumbersome. The segmentation plugin always tries to do automated node selection which is often confusing from user point of view.

Additional the code which realized this auto selection is very confusing and hence near not maintainable.

Proposed solution:

  1. Clean up code for auto selection
  2. Add new preference which allows the user to enable/disable autoselection
  3. Add new datastorage selection box for segmentation to specify selected patient and segmentation image

Event Timeline

Updating target milestone to upcoming release

New remote branch pushed: bug-13514-improve-segmentation-selection-behavior-without-ws

New remote branch pushed: bug-13514-improve-segmentation-selection-behavior-integration

New remote branch pushed: bug-13514-segmentation-selection-final

[9533d0]: Merge branch 'bug-13514-segmentation-selection-final-integration'

Merged commits:

2013-04-18 10:00:09 Andreas Fetzer [f632af]
Fixed wrong application of dislay preferences

2013-04-17 10:45:54 Andreas Fetzer [0cb3cb]
Fixed crash during removing of observers

2013-04-17 09:40:12 Andreas Fetzer [808216]
Removed uncommented code

2013-04-17 09:39:25 Andreas Fetzer [f6bdcf]
Fixed crash on closing MITK when binary property is changed

2013-04-16 23:21:49 Andreas Fetzer [d4e40b]
Disabled autoselection if segmentation view is deactivated

2013-04-16 23:17:58 Andreas Fetzer [dd9a0c]
Fixed an issue where a reference image becomes invisible when selected

2013-04-16 19:46:37 Andreas Fetzer [76b569]
Merge branch 'bug-13514-final-segmentation-selection-integration' into bug-13514-segmentation-selection-final-integration


2013-02-22 00:14:35 Andreas Fetzer [1dbdc9]
Fixed some selection issues

2013-01-22 10:15:59 Andreas Fetzer [5194aa]
Fixed wrong warning if no autoselection is enabled and the selection of the comboboxes is changing

2013-01-22 10:09:57 Andreas Fetzer [87e626]
Observer are no longer added to helper objects.

2013-01-22 10:09:35 Andreas Fetzer [fa6d89]
Fixed a bug in the interpolation

2013-01-22 09:49:41 Andreas Fetzer [15a294]
Fixed wrong behaviour after node was removed

2013-01-22 09:49:24 Andreas Fetzer [e634ec]
Fixed issue that segmentation and reference image were not correctly detected after the segmentationView was opened

2013-01-21 15:05:17 Andreas Fetzer [39e838]
Declared the function NewNodesGenerated as deprecated and added a according warning

2013-01-21 15:04:37 Andreas Fetzer [7944e8]
General code cleaning. Removed a lot of functions which are obsolet or unnecessary by now.
Removed the SegmentationPostProcessing which was replaced by the ExtentionPoints.
Removed the AlignmentChecking function which are not needed anymore due to changes of the reslicing system.

2013-01-21 15:00:02 Andreas Fetzer [89828b]
Wrote function for checking the geometry of two selected images. This is needed if the segmentation and the patient images are loaded separatly

2013-01-21 14:58:09 Andreas Fetzer [1b873f]
Cleaned up includes of SegmentationView

2013-01-21 17:37:20 Andreas Fetzer [95dfb5]
Enhanced ToolManager so that ToolBox is only enabled if the nodes are selected AND visible

2013-01-21 14:55:33 Andreas Fetzer [22f70e]
Reworked the OnSelectionChanged function so that the current set SelectionModus is taken into account

2013-01-21 14:54:02 Andreas Fetzer [79fae8]
Created observer for changed binary property and for changed visibility of a segmentation

2013-01-21 14:45:18 Andreas Fetzer [73f3ab]
Created Comboboxes for segmentation and patient images. Create on single label for segmentation warning and an according update warning label function. Wrote according ComboboxSelectionChanged function and adapted function SetToolManagerSelection

2013-01-21 09:39:36 Andreas Fetzer [c2bd87]
Created NodePredicateMembers

2013-01-21 09:37:11 Andreas Fetzer [e34e9a]
Integrated new segmentation preference in segmentationView

2013-01-21 09:34:04 Andreas Fetzer [bb73ec]
Created new preference for the segmentation plugin's auto-selection mode

Reopened bug since auto selection is currently disable by default.

[a95f2d]: Merge branch 'bug-13514-segmentation-selection-final-integration'

Merged commits:

2013-04-18 14:02:12 Andreas Fetzer [6a67ac]
Enabled auto-selection by default