Page MenuHomePhabricator

FitGeometry never set back ChangeImageGeometryConsideringOriginOffset
Closed, DuplicatePublic

Description

The FitGeometry method makes a call to

ChangeImageGeometryConsideringOriginOffset(false)

but never sets it back to true. This cause a missing pixel row in the display afterward (on our toy 9x9x9 image, see attachement).

This bug impacts the imagecropper plugins and any other plugins that mimics its behavior for bounding box selection.

Event Timeline

Thank you for reporting this, unfortunately I won't be able to look after this bug before June 15th.

@Basti: Could you maybe have a look at this bug, or find someone who can?

In the current source code, there is no call
ChangeImageGeometryConsideringOriginOffset(false)
in the FitGeometry method anymore.

However, we still have problems with that image cropper and the boundinggeometry class. This is currently being worked on in a different bug.