Page MenuHomePhabricator

Diffusion control area does not update on implicit selection change
Closed, ResolvedPublic

Description

To reproduce:

  1. Load a dwi image and select it in the datamanager
  2. Start Tesnor reconstruction
  3. The dwi image will no longer be selected, but the diffusion control area will show the buttons as if it were

Event Timeline

this is fixed in the currect master. but a similiar problem remains.
the original image remains selected, but the newly generated is shown.

therefore, the original datanode is unselected by calling SetSelected(false).

this call, however, does not trigger any OnSelectionChanged events,
so the diffusion control area is still visible,
manually invoking the OnSelectionChanged event does not seem like a good idea.

New remote branch pushed: bug-14641-UnSelectDataNodeAfterTensorsGeneration

I don't think the newly added node should be selected automatically.

Reopen as the following problem still remains:

When a node is added and the original node therefore implicitly deselcted, the control area remains as if it was still selected. It will update on an additional click.

This might however confuse users, as the buttons suddenly disappear when they are clicking them. Instead it should disappear upon the implicit deselection.

In the current master the newly added node is not selected automatically --> no problem. In general, the selection/deselction of nodes in the source code should probably trigger a SelectionChanged event.