Page MenuHomePhabricator

Now newline at end of files mitkExtractSliceFilter.cpp and mitkPlaneClipping.h
Closed, ResolvedPublic

Description

newlines are missing at the end of the files:
-mitkExtractSliceFilter.cpp
-mitkPlaneClipping.h

this leads to compile errors under the platform slackware/32bit:

In file included from /build/niftk-release/CMakeExternals/Source/MITK/Core/Code/Algorithms/mitkExtractSliceFilter.cpp:23:
/build/niftk-release/CMakeExternals/Source/MITK/Core/Code/Algorithms/mitkPlaneClipping.h:141:7: error: no newline at end of file

hashtag: 626784deb8f6ffb32664b70c33e778367f1bf45a
(from March 1)

Related Objects

Event Timeline

Creating a new wiki page for the core change request is not possible at the moment (something is down). So here is the change request:

Summary of problem description:

Newline at EoF is missing in files mitkExtractSliceFilter.cpp and mitkPlaneClipping.h

Actual behavior:

This leads to compile errors under slackware/32bit.

Expected behavior:

Not error messages because of missing newlines at EoF.

Cause of the bug:

missing newline at EoF in files mitkExtractSliceFilter.cpp and mitkPlaneClipping.h

Proposed solution:

add a newline at EoF in files mitkExtractSliceFilter.cpp and mitkPlaneClipping.h

Affected classes:

mitkExtractSliceFilter.cpp, mitkPlaneClipping.h

How will the bugfix get tested?

The commit-hook will check if the style is ok. Afterwards compile the code under slackware and see if the errors are solved.

Hasn't this been fixed in T14640 already?

This has been fixed. I closed the other ticket, but not this.

As I see, I don't have the right to close this. Feel free to close it, it's resolved. Thanks!