| engelm | |
| Mar 14 2013, 11:56 AM |
| F971: interpolationsegmentation.diff | |
| Mar 14 2013, 2:33 PM |
All classes that are related to interpolation are currently located in mitkEXT. As mitkEXT is only a set of classes that did not fit in the core, it is ugly to have a dependency to mitkEXT.
Thus it would be nice to move the classes related to the interpolation into a new module 'SurfaceInterpolation'.
To get the interpolation related classes out of MitkExt a couple of classes have to be moved:
classes moved from MitkExt to Core:
classes moved from Segmentation to SurfaceInterpolation:
Patch that moves the files related to the interpolation of surfaces into a distinct module called SurfaceInterpolation. This new module has no dependency to MitkExt.
I have created a new Branch 'bug-14763-move-classes-from-mitkExt' that moves classes from MitkExt to other modules:
MitkExt to Core (commit rMITK4088338fcc74):
These files should be moved to the Core as they are pretty basic filters.
MitkExt to new module MultiLabelSegmentation (commit rMITK44eed7790847) :
MultiLabelSegmentation shall be encapsulated in a distinct module, not in MitkExt.
MitkExt to new module SurfaceInterpolation (commit rMITK738866185797):
These files should be moved to a distinct module to make them usable in other interpolation related modules without needing a dependency to MitkExt.
Andreas, can you take a look at this and tell me if this works for you?
We just had a phone call with Andreas Fetzer. The problem here is with class SeedsImage, which is practically deprecated and should not be moved into a new module. Rather we'll create such a module in a private branch and wait to switch to new multi-label classes which are under planning already.
I have created a new Branch 'bug-14763-move-classes-to-correct-modules' containing the relevant changes under consideration of the recent discussions between Daniel, Andreas and myself:
MitkExt to Core (commit rMITK9f06035577e0):
These files should be moved to the Core as they are pretty basic filters. mitkTimeHelper.h is used in SurfaceToImageFilter.
MitkExt to ImageExtraction (commit rMITKc5540c8a72fe):
This filter extracts a part of the image, so it belongs into the ImageExtraction module.
Segmentation to new module SurfaceInterpolation (commit rMITKa15dfda6b41c):
These files should be moved to a distinct module to make them usable in other interpolation related modules without needing a dependency to Segmentation.
I forgot to mention that all SeedsImage related classes will NOT be moved from MitkExt as those classes are considered (not yet officially declared) deprecated.
Andi, could you take a look at this? If you approve, I'll ask Daniel to give me the Core-Mod '+'
This bug could not be fixed within the 2013-06 release and has medium severity. Setting target milestone to unspecified.
I have rebased the branch onto the current master once again to avoid nasty merge-conflicts that would have occured with the old branch.
[653527]: Merge branch 'bug-14763-move-classes-rebased'
2013-07-05 16:51:36 Markus Engel [d2613f]
removed unnecessary export macros
2013-07-05 11:51:55 Markus Engel [f2fcb1]
fixing dependency of PlanarFigureInterpolation to new module
2013-07-05 11:51:41 Markus Engel [5abb37]
moving interpolation related classes to distinct module
2013-07-05 11:51:10 Markus Engel [8dc845]
moving ImageToSurface and SurfaceToImageFilter to Core
2013-07-05 11:50:18 Markus Engel [7c64e9]
moving AutoCropImageFilter to ImageExtraction module
[98c85e]: COMP: Merge branch 'bug-14763-move-classes-rebased'
2013-07-05 17:34:09 Markus Engel [0aa3ee]
dummy commit to be able to comp
[0283ad]: COMP: Merge branch 'bug-14763-move-classes-rebased'
2013-07-05 17:52:58 Markus Engel [e3070f]
trying to fix compiler warning on gcc
All classes have been correctly moved as described above.
This bug can be closed now...