Page MenuHomePhabricator

Make FileReader and FileWriter Microservice-based
Closed, ResolvedPublic

Description

This is the playground for my Platform Project. In this bug I will create a Microservice Interface for FileReader and FileWriter.

Related Objects

Event Timeline

New remote branch pushed: bug-14866-MakeFileReaderAndFileWriterMicroserviceBased

New remote branch pushed: bug-14866-MakeFileReaderAndFileWriterMicroserviceBasedITK4

Hi,
tested legacy mechanism of feature branch 14866 and encountered issue with unsorted lists in mitkCoreObjectFactory.cpp 414

allWriters.merge(list2);

In debug mode, xutility throws a debug error in method _Debug_order_2 (line 744) and marks, that the sequence is not ordered.

In my applications workbench_window_advisor I am registering extra ObjectFactories. When I disable this it works fine.
I know, this will be deprecated anyway, but wanted to inform you for this issue. Might also be ok if the registering will be moved to the module's section as the calls then will be done later.
(keep up the great work! much appreciated!!!)

Call stack:

	msvcp100d.dll!std::_Debug_message(const wchar_t * message=0x000007fee2520ab8, const wchar_t * file=0x000007fee202c900, unsigned int line=1295)  Line 15	C++
	Mitk.dll!std::_Debug_order2<std::_List_iterator<std::_List_val<itk::SmartPointer<mitk::FileWriterWithInformation>,std::allocator<itk::SmartPointer<mitk::FileWriterWithInformation> > > > >(std::_List_iterator<std::_List_val<itk::SmartPointer<mitk::FileWriterWithInformation>,std::allocator<itk::SmartPointer<mitk::FileWriterWithInformation> > > > * _First=0x000000000024aa08 {m_Pointer=0x000000000420d0a0 }, std::_List_iterator<std::_List_val<itk::SmartPointer<mitk::FileWriterWithInformation>,std::allocator<itk::SmartPointer<mitk::FileWriterWithInformation> > > > * _Last=0x000000000024a9e8 {m_Pointer=0xcdcdcdcdcdcdcdcd }, const wchar_t * _File=0x000007fee202c900, unsigned int _Line=1295, std::forward_iterator_tag __formal={...})  Line 745	C++
	Mitk.dll!std::_Debug_order<std::_List_iterator<std::_List_val<itk::SmartPointer<mitk::FileWriterWithInformation>,std::allocator<itk::SmartPointer<mitk::FileWriterWithInformation> > > > >(std::_List_iterator<std::_List_val<itk::SmartPointer<mitk::FileWriterWithInformation>,std::allocator<itk::SmartPointer<mitk::FileWriterWithInformation> > > > * _First=0x000000000024abe8 {m_Pointer=0x00000000042061a0 }, std::_List_iterator<std::_List_val<itk::SmartPointer<mitk::FileWriterWithInformation>,std::allocator<itk::SmartPointer<mitk::FileWriterWithInformation> > > > * _Last=0x000000000024abc8 {m_Pointer=0xcdcdcdcdcdcdcdcd }, const wchar_t * _File=0x000007fee202c900, unsigned int _Line=1295)  Line 752 + 0xae bytes	C++
	Mitk.dll!std::list<itk::SmartPointer<mitk::FileWriterWithInformation>,std::allocator<itk::SmartPointer<mitk::FileWriterWithInformation> > >::merge(std::list<itk::SmartPointer<mitk::FileWriterWithInformation>,std::allocator<itk::SmartPointer<mitk::FileWriterWithInformation> > > & _Right=[3]({m_Pointer=0x00000000042061a0 },{m_Pointer=0x000000000420d0a0 },{m_Pointer=0x000000000420c3e0 }))  Line 1297	C++
	Mitk.dll!mitk::CoreObjectFactory::GetFileWriters()  Line 414 + 0x12 bytes	C++
	Mitk.dll!mitk::CoreObjectFactory::RegisterLegacyWriters()  Line 455 + 0x1e bytes	C++
	Mitk.dll!mitk::CoreObjectFactory::RegisterExtraFactory(mitk::CoreObjectFactoryBase * factory=0x00000000041dea90)  Line 88	C++

MitkExt.dll!RegisterCoreExtObjectFactory() Line 189 + 0x6c bytes C++

	liborg_mitk_core_ext.dll!mitk::CoreExtActivator::start(ctkPluginContext * context=0x0000000003e7a070)  Line 41	C++
	CTKPluginFramework.dll!ctkPluginPrivate::start0()  Line 745	C++
	CTKPluginFramework.dll!ctkPluginPrivate::finalizeActivation()  Line 370 + 0xd bytes	C++
	CTKPluginFramework.dll!ctkPlugin::start(const QFlags<enum ctkPlugin::StartOption> & options={...})  Line 115	C++
	CTKPluginFramework.dll!ctkPluginPrivate::startDependencies()  Line 715 + 0x45 bytes	C++
	CTKPluginFramework.dll!ctkPluginPrivate::finalizeActivation()  Line 370	C++
	CTKPluginFramework.dll!ctkPlugin::start(const QFlags<enum ctkPlugin::StartOption> & options={...})  Line 115	C++
	liborg_blueberry_osgi.dll!berry::IConfigurationElement::CreateExecutableExtension<berry::IApplication>(const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & propertyName="class")  Line 94	C++
	liborg_blueberry_osgi.dll!berry::Starter::Run(int & argc=1, char * * argv=0x0000000001d9b7b0, Poco::Util::AbstractConfiguration * config=0x0000000001da8b60)  Line 173 + 0x3a bytes	C++

...

unsorted list bug resolved in 2013.09.0 release

ok, no errors because not contained in release 2013.09.0!!!

Bug still is present. Reported more detailed discription in #16437.

New remote branch pushed: bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2013-12

Hi,
when will the branch be integrated? I was working on an own Surface writer but then saw, that the writer mechanism is hard coded as well!
I would be very very interested in the integration *vote*!

User zelzer has pushed new remote branch:

bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2014-03

[066a59]: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2

Merged commits:

2014-10-01 06:37:14 Sascha Zelzer [644df5]
Use a mitk::CoreObjectFactoryBase for legacy reader / writer.


2014-10-01 04:58:15 Sascha Zelzer [b6361b]
Fixed compiler errors due to previous changes.


2014-10-01 04:57:29 Sascha Zelzer [227ea1]
Provide a better default for old CanWriteDataType.


2014-10-01 06:39:13 Sascha Zelzer [8f8cfb]
Fixed Windows compiler errors.


2014-10-01 03:16:43 Sascha Zelzer [143edb]
Fixed CMake issues with test driver.


2014-10-01 03:16:10 Sascha Zelzer [257c80]
Properly handle legacy writer memory management.


2014-10-01 02:36:00 Sascha Zelzer [d2125a]
Consider super class hierarchy when matching writers.


2014-09-30 15:24:00 Sascha Zelzer [e44755]
Compiler fixes for changes in the core.


2014-09-30 11:06:50 Sascha Zelzer [1525ba]
Added file writer service for legacy FileWriter objects.


2014-09-30 11:05:32 Sascha Zelzer [572fe7]
Added GetSupportedBaseData() method to old FileWriter interface.


2014-09-30 11:04:08 Sascha Zelzer [3dfaf6]
Configurable mime-type prefix for reader and writer.


2014-09-30 00:31:24 Sascha Zelzer [6fa4b8]
Extraced common interface for IFileReader and IFileWriter.


2014-09-30 00:13:52 Sascha Zelzer [7cafec]
Added explicit SetInput() methods and relatives.


2014-09-29 09:54:40 Sascha Zelzer [67a655]
Merge branch 'master' into bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2014-03

Conflicts:
Core/Code/IO/mitkIOUtil.cpp
Core/Code/IO/mitkIOUtil.h
Core/Code/IO/mitkImageWriter.cpp
Core/Code/Testing/mitkExtractSliceFilterTest.cpp
Core/Code/Testing/mitkImageDimensionConverterTest.cpp
Core/Code/Testing/mitkImageToItkTest.cpp
Modules/SceneSerialization/CMakeLists.txt
Plugins/org.mitk.gui.qt.datamanager/src/QmitkDataManagerView.cpp
Plugins/org.mitk.gui.qt.ext/src/QmitkExtWorkbenchWindowAdvisor.cpp


2014-09-29 04:21:32 Sascha Zelzer [0f9a69]
Reworked mime types and load/save logic; added confidence levels.


2014-09-29 04:01:55 Sascha Zelzer [4ab312]
Consistently create a module context for test drivers.


2014-09-29 03:58:44 Sascha Zelzer [aa18cb]
Geometry Clone() plus unused variable fixes.


2014-07-21 13:36:53 Sascha Zelzer [f6ec83]
New base class for creating reader and writer in one implementation.


2014-07-10 00:11:43 Sascha Zelzer [185103]
Added support for writing one or more base data objects.


2014-07-07 22:38:50 Sascha Zelzer [427bc2]
Reworked reader writer interfaces and adapted tests.


2014-06-14 01:48:46 Sascha Zelzer [82ed07]
Some clean-up of file writer related classes.


2014-06-12 10:49:19 Sascha Zelzer [8ed26c]
Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2013-12' into bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2014-03

Conflicts:
CMake/mitkSetupVariables.cmake
Core/Code/Controllers/mitkCoreActivator.cpp
Core/Code/Rendering/mitkRenderingTestHelper.h
Core/Code/Testing/mitkDICOMLocaleTest.cpp
Core/Code/Testing/mitkImageTest.cpp
Core/Code/files.cmake
Modules/CMakeLists.txt
Modules/IpPicSupport/CMakeLists.txt
Modules/IpPicSupportIO/CMakeLists.txt
Modules/LegacyIO/mitkFileSeriesReader.h
Modules/LegacyIO/mitkImageWriter.cpp
Modules/LegacyIO/mitkItkImageFileReader.h
Modules/LegacyIO/mitkRawImageFileReader.h
Modules/LegacyIO/mitkSTLFileReader.h
Modules/LegacyIO/mitkSurfaceVtkWriter.h
Modules/LegacyIO/mitkVtiFileReader.h
Modules/LegacyIO/mitkVtkImageReader.h
Modules/LegacyIO/mitkVtkSurfaceReader.h
Modules/MitkAlgorithmsExt/Testing/mitkBoundingObjectCutterTest.cpp
Modules/MitkDataTypesExt/Testing/mitkCompressedImageContainerTest.cpp
Modules/MitkExt/CMakeLists.txt
Modules/MitkIOExt/CMakeLists.txt
Modules/PlanarFigure/CMakeLists.txt
Modules/Qmitk/CMakeLists.txt
Modules/Qmitk/QmitkIOUtil.cpp
Modules/Qmitk/QmitkIOUtil.h
Modules/Qmitk/QmitkServiceListWidget.h
Modules/QmitkExt/files.cmake
Modules/SceneSerialization/CMakeLists.txt


2014-03-14 12:24:24 Sascha Zelzer [9c0eae]
Addapted code to changes in AbstractFileReader.


2014-01-29 09:38:29 Sascha Zelzer [3704b5]
Improved AbstractFileReader and ITK ImageIO support.


2014-01-17 02:34:27 Sascha Zelzer [9771eb]
Moved LookupTableProperty class to the correct folder.


2014-01-17 02:33:41 Sascha Zelzer [f98039]
Moved non-public files to Internal folder.


2014-01-17 01:25:44 Sascha Zelzer [1660da]
Updated version in deprecated info.


2013-12-26 00:24:43 Sascha Zelzer [51ad25]
Fixed bugs revealed by failing reader/writer tests.


2013-12-26 00:23:36 Sascha Zelzer [2555c6]
Catch exceptions during destruction.


2013-12-26 00:15:47 Sascha Zelzer [38fd06]
Adapted deprecated statements for legacy reader and writer.


2013-12-25 16:51:13 Sascha Zelzer [bc0095]
Merge remote-tracking branch 'origin/bug-16699-split-up-MitkExt-module' into bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2013-12

Conflicts:
CMake/mitkSetupVariables.cmake
Core/Code/Common/mitkCoreObjectFactory.cpp
Core/Code/Common/mitkCoreObjectFactory.h
Core/Code/Controllers/mitkCoreActivator.cpp
Core/Code/Testing/mitkDICOMLocaleTest.cpp
Modules/CMakeLists.txt
Modules/IpPicSupport/CMakeLists.txt
Modules/QmitkExt/files.cmake


2013-12-19 03:39:27 Sascha Zelzer [ce7976]
Merge remote-tracking branch 'origin/bug-14866-MakeFileReaderAndFileWriterMicroserviceBasedITK4' into bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2013-12

Conflicts:
Core/Code/CMakeLists.txt
Core/Code/Common/mitkCoreObjectFactory.cpp
Core/Code/Common/mitkCoreObjectFactory.h
Core/Code/Testing/mitkImageTimeSelectorTest.cpp
Core/Code/files.cmake
Modules/OpenCVVideoSupport/Testing/mitkOpenCVMitkConversionTest.cpp
Modules/Qmitk/CMakeLists.txt
Plugins/org.mitk.gui.common/src/mitkWorkbenchUtil.cpp


2013-09-10 09:00:17 Sascha Zelzer [6a5a53]
Fixed Windows compilation issues.


2013-09-05 00:14:56 Sascha Zelzer [4548ef]
Added a native file open dialog.


2013-09-05 00:11:56 Sascha Zelzer [69ca08]
Moved QmitkIOUtil to Qmitk and added a LoadFiles(...) methods.


2013-09-05 00:08:54 Sascha Zelzer [4d81f4]
Enabled LegacyIO activator and added mime-types.


2013-09-05 00:07:06 Sascha Zelzer [d8c765]
Added mime-type support to the IFileReader interface, plus more clean-up.


2013-09-03 22:04:29 Sascha Zelzer [0358c9]
Cleanup open and save dialogs.


2013-09-03 22:03:42 Sascha Zelzer [246dcc]
Unregister legacy file writer on destruction.


2013-09-03 12:36:57 Sascha Zelzer [a9d91d]
Created LegacyIO module containing old reader and writer.


2013-08-30 18:27:55 Keno Maerz [cbbfa4]
Modified the activator to register Reader and Writer service.


2013-08-30 18:27:14 Keno Maerz [c6d87e]
Added PointSetReaderService and PointSetWriterService. The latter is still unimplemented.


2013-08-30 18:26:23 Keno Maerz [65febd]
Cleaning, added methods for ProgressCallback and removed old getProgress


2013-08-28 12:51:18 Keno Maerz [37a685]
replaced all lists with vectors, renamed tests


2013-08-27 11:01:03 Sascha Zelzer [cc2bce]
Add default implementations for reading from and writing to streams.

Plus some small clean-ups.


2013-08-27 10:59:51 Sascha Zelzer [eedca0]
Added a Write(BaseData*, std::ostream&) method and stream-lined GetWriter()


2013-08-27 10:54:30 Sascha Zelzer [fdeb7c]
Use typedef for reader/writer options and option lists.


2013-08-27 10:45:25 Sascha Zelzer [690126]
Renamed mitk::File*Manager to mitk::File*Registry in tests.


2013-08-27 10:37:59 Sascha Zelzer [6633a4]
Added GetStaticNameOfClass() method to the mitkClassMacro.


2013-08-27 11:03:50 Sascha Zelzer [b97187]
Merge commit '21714975ae487f9108221aa26dfbfec899587a61' into bug-14866-MakeFileReaderAndFileWriterMicroserviceBasedITK4


2013-08-27 11:03:50 Sascha Zelzer [217149]
Squashed 'Core/CppMicroServices/' changes from 100cffb..2a5abcb

2a5abcb Fixed OR operator for LDAP expressions.
70acf9e Added support for NULL values in LDAP expressions.
01a4608 Disable warning 4503 (decorated name length exceeded).

git-subtree-dir: Core/CppMicroServices
git-subtree-split: 2a5abcb34ed09599031a39f079e57515d3f23022


2013-08-27 10:33:44 Keno Maerz [03a47d]
Preparing FileOpenDialog to be able to open many files at once. Dialog temporally broken...


2013-08-26 17:31:49 Keno Maerz [25ec06]
Renamed xxxManager to xxxRegistry, removed unnecessary imports, fixed local creation of FileReaderRegisrty in FileOpenDialog


2013-08-26 16:52:55 Keno Maerz [006e4a]
Documentation


2013-08-26 14:50:34 Keno Maerz [ed3d1e]
Functionality of the mitk Dialogs mostly finished


2013-08-26 14:16:08 Keno Maerz [3d3d37]
Better separation of QmitkFileDialog and QmitkFileOpenDialog, adapted QmitkFileSaveDialog


2013-08-26 13:34:22 Keno Maerz [6434fb]
moved declaration of FileServiceOption from mitk into IFileReader Namespace


2013-08-26 12:57:06 Keno Maerz [5dbe56]
Seperated QmitkFileDialog into abstract QmitkFileDialog and QFileOpenDialog. Added QmitkFileSaveDialog


2013-08-26 11:18:03 Keno Maerz [2bd110]
QmitkFileDialog cann ow read BaseData directly. Fixed FileWriter not having Options set.


2013-08-23 17:11:13 Keno Maerz [43a064]
New QmitkFileDialog can Open Files. Still in development.


2013-08-23 17:10:35 Keno Maerz [9ff380]
Remodeled Options System. Now 200% better than before.


2013-08-22 17:19:56 Sascha Zelzer [2cc2f9]
Fixed compile error with gcc.


2013-08-22 16:17:50 Sascha Zelzer [8efdee]
Merge branch 'bug-15888-temporary-files-and-dirs' into bug-14866-MakeFileReaderAndFileWriterMicroserviceBasedITK4

  • bug-15888-temporary-files-and-dirs: (149 commits) Added methods for creating temporary files and directories. Added DCMTK to the library search path, since it is build shared now. Correct error in filtername Removed extra export macro Revert "COMP: Added mising Export macro" COMP: Added missing typenames COMP: Added mising Export macro COMP: Explicitely using type instead of Self Made call to std::make_pair() compatible to MSVC 2012. Removing resource file from non-qt folder removed unnecessary file from non-qt module folder Added custom test for HeadMotionCorrection Finalizing filter COMP: Corrected boost path for tests. Fixed pre-processor macro name Fixing output initialization Enhance generate output COMP: SOFA should always find boost now. COMP: Boost should use the right toolset for building the libraries now. Removing unnecessary casts ...

Conflicts:
Core/Code/files.cmake


2013-08-21 18:19:59 Keno Maerz [6465e0]
Created new QMITKFileDialog that will support Options


2013-08-19 17:26:14 Keno Maerz [df2dc6]
Renamed ConstructServiceProperties to GetServiceProperties


2013-08-19 17:22:25 Keno Maerz [d99e26]
Removed Metadata related getters from Interfaces.
Removed Constructors containing initializations for filepattern-related fields


2013-08-19 17:15:25 Keno Maerz [3c1ca0]
Removed FilePattern related methods


2013-08-19 09:38:50 Sascha Zelzer [43b206]
Using prototype service factories for readers and writers now.

The reader/writer manager classes now return new IFileReader and
IFileWriter instances by internally using us::ServiceObjects. They
also bind the life-time of the new instances to their own to not
leak memory, therefore the methods cannot be static any more.


2013-08-18 17:08:38 Sascha Zelzer [660c52]
Reworked the AbstractFile(Reader|Writer)::RegisterService() method.


2013-08-17 18:38:48 Sascha Zelzer [c819ec]
Cleaned up header files and some imlementation code.

  • Removed unnecassary includes
  • More const and raw pointer arguments
  • No itk::LightObject inheritance
  • Consistent for loops
  • Make use of superclass constructors

2013-08-13 10:43:31 Sascha Zelzer [6c39f2]
Improved a couple of method signatures.


2013-08-18 19:30:10 Sascha Zelzer [f0d88c]
Adapt to CppMicroServices API changes.


2013-08-18 19:10:38 Sascha Zelzer [b98bb6]
Merge branch 'bug-15707-cppmicroservices-api-version-2-subtree' into bug-14866-MakeFileReaderAndFileWriterMicroserviceBasedITK4


2013-08-13 00:19:33 Sascha Zelzer [f0728a]
Fixed compilation errors on Linux.


2013-06-11 17:52:38 Keno Maerz [57b07b]
Merge remote-tracking branch 'remotes/origin/bug-14866-MakeFileReaderAndFileWriterMicroserviceBased' into bug-14866-MakeFileReaderAndFileWriterMicroserviceBasedITK4

Conflicts:
Core/Code/Testing/files.cmake


2013-06-11 17:46:07 Keno Maerz [82bd84]
More Documentation


2013-06-11 17:26:41 Keno Maerz [2d9f4c]
Documentation


2013-06-07 11:54:06 Keno Maerz [a3b4a9]
Implemented FileWriters


2013-06-03 11:02:03 Keno Maerz [ba9679]
FileWriter Interfaces now carry optional pointer to DataStorage in read method header


2013-06-03 10:46:50 Keno Maerz [50421a]
Refactored Read to return list of pointer instead of single pointer


2013-05-31 14:21:37 Keno Maerz [46b454]
Fixed code that prevents duplicate LegacyFileReader Registrations


2013-05-31 13:26:26 Keno Maerz [196115]
Moved Legacy Reader Registration to CoreObjectFactory


2013-05-31 12:56:22 Keno Maerz [d02f92]
Disabled FilePattern mechanic


2013-05-24 17:00:41 Keno Maerz [f197e6]
FileReaderManager can now instantiate all necessary legacy Readers automagically (but does not care about doubles yet)


2013-05-24 11:33:56 Keno Maerz [00489f]
Added ReadAll Method for convenience


2013-05-23 15:50:08 Keno Maerz [ae151b]
GetSupportedExtensions can now be called with a parameter to filer to a certain extension


2013-05-23 15:38:35 Keno Maerz [ed0254]
FileReaderManager can now generate QFileDialog string


2013-05-22 11:44:48 Keno Maerz [68ed2c]
Added FileWriter Classes


2013-05-21 16:23:09 Keno Maerz [7879d3]
Added constants for Option to read multiple files. Also: Documentation


2013-05-21 14:37:29 Keno Maerz [b39565]
Added Support for Reader Descriptions


2013-05-14 15:28:27 Keno Maerz [aeb6a0]
Removed problematic Microservice unregistration in destructor


2013-05-14 15:25:32 Keno Maerz [eda1d1]
LegacyReader works by wrapping IOUtil


2013-05-14 15:08:17 Keno Maerz [e2225a]
Templated Read-method for Reader Manager


2013-05-14 11:37:40 Keno Maerz [b2b96a]
Experimental commit on the legacy reader, might change significantly in next commit


2013-05-10 13:14:29 Keno Maerz [96bd38]
Throw exception if read was called and no matching Reader could be found


2013-04-18 14:07:49 Keno Maerz [965038]
Removed now superficial dummy implementation of read from FileReaderManagerTest


2013-04-18 14:06:01 Keno Maerz [affe78]
Implemented read(string) Method, so that it checks for file existence and creats a stream which it passes to Read(istream).


2013-04-18 12:41:42 Keno Maerz [4dfb9e]
Added UnregisterMicroservice and made sure destructor calls it.


2013-04-18 12:41:06 Keno Maerz [a38eeb]
Renamed Microservice Related String Constants Prefix from US_ to PROP_


2013-04-17 20:37:08 Keno Maerz [6d10f1]
Changed Filenames according to convention


2013-04-17 17:35:39 Keno Maerz [249ed0]
Removed Read from memory methods, as they are being replaced by Read from InputStream Method


2013-04-17 16:50:59 Keno Maerz [340cff]
AbstractFileReader does not inherit from lightobject anymore. Inheriting classes have to inherit from lightobject if they want the reader to be registered as a Microservice.

Also: Some code cleaning


2013-04-17 16:19:16 Keno Maerz [7a9a8b]
Const-Changes from szelzer's advise


2013-04-15 14:12:00 Keno Maerz [bd4c32]
Somem ore default implementations for Abstract Class


2013-04-15 11:27:10 Keno Maerz [e8256e]
Applied context trick to all ReaderManager Methods. This way, The user can just call the methods without aquiring a ReaderManager, but still the correct context is used.


2013-04-15 11:18:58 Keno Maerz [cdfc7a]
Moved Microservice Registration Logic to Abstract Class


2013-04-12 16:52:10 Keno Maerz [8940d3]
More trivial methods implemented in Abstract FileReader. Test now operates on Abstract FileReader instead of the Interface.


2013-04-12 16:44:17 Keno Maerz [4ec944]
Exchanged const char * with std::string for filenames, patters etc.


2013-04-12 16:09:38 Keno Maerz [d5e5af]
FileName handling now in abstract superclass


2013-04-12 15:31:35 Keno Maerz [19838c]
Using common Service Ranking instead of private service Priority


2013-04-12 11:15:31 Keno Maerz [8ce5db]
Extracted FileReader Interface and created new abstract class. Moved some files to better directories.


2013-04-10 15:09:15 Keno Maerz [502f48]
Const-Pointer in method headers


2013-04-09 15:24:54 Keno Maerz [b13419]
Cpmplete Implementation of Reader Manager, far more extensive testing.


2013-04-09 14:47:10 Keno Maerz [a03668]
Readers Manager can now handle options


2013-04-08 18:29:18 Keno Maerz [3b47d6]
Priorizing FIleReaderInterfaces now works


2013-04-08 17:59:47 Keno Maerz [ac7b2c]
Retrieving Reader by extension working


2013-03-28 16:19:20 Keno Maerz [be414d]
Adding a test file for FileReaderManager


2013-03-28 15:56:21 Keno Maerz [a243f7]
First code for Interfaces

[7df1c2]: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2

Merged commits:

2014-10-01 11:33:50 Jan Hering [3eda76]
COMP: Move Exception::operator<< into mitk namespace


2014-10-01 11:32:35 Jan Hering [3e6580]
COMP: Removed unused private members

  • causing Wunused-private-field on clang

[5563b3]: Merge branch 'bug-14866-reader-writer-dashboad-fixes'

Merged commits:

2014-10-01 12:49:54 Andreas Fetzer [83710a]
COMP Fixed core warning due to missing base class initialization

[5cff03]: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2

Merged commits:

2014-10-01 13:00:40 Jan Hering [c0b33b]
COMP: Fixed namespace of operator<< implementation

[b9bccb]: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2

Merged commits:

2014-10-01 14:56:25 Sascha Zelzer [9ba026]
COMP: Added missing pure virtual override.


2014-10-01 13:48:49 Jan Hering [72b2e8]
Merge branch 'bug-14866-reader-writer-dashboad-fixes' into bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2014-03

[5eb77d]: COMP: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceB

Merged commits:

2014-10-02 11:32:17 Sascha Zelzer [ce3aac]
Fixed STL file reader test.


2014-10-02 01:21:06 Sascha Zelzer [c97f90]
Work on reactivating mitkImageWriterTest.

[f1f2a8]: COMP: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceB

Merged commits:

2014-10-02 14:28:34 Sascha Zelzer [62814e]
Fixed usage of new SaveInfo constructor.

[db3439]: COMP: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceB

Merged commits:

2014-10-06 09:05:24 Sascha Zelzer [b2079f]
Added vtk image and surface I/O and removed deprecated IpPic module.

[8e8003]: COMP: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceB

Merged commits:

2014-10-07 04:13:27 Sascha Zelzer [42b974]
Use mitk::IOUtil in SceneSerialization.


2014-10-07 04:12:55 Sascha Zelzer [0edd8b]
Added missing virtual destructor.

[8e8003]: COMP: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceB

Merged commits:

2014-10-07 04:13:27 Sascha Zelzer [42b974]
Use mitk::IOUtil in SceneSerialization.


2014-10-07 04:12:55 Sascha Zelzer [0edd8b]
Added missing virtual destructor.

[8e8003]: COMP: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceB

Merged commits:

2014-10-07 04:13:27 Sascha Zelzer [42b974]
Use mitk::IOUtil in SceneSerialization.


2014-10-07 04:12:55 Sascha Zelzer [0edd8b]
Added missing virtual destructor.

[8e8003]: COMP: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceB

Merged commits:

2014-10-07 04:13:27 Sascha Zelzer [42b974]
Use mitk::IOUtil in SceneSerialization.


2014-10-07 04:12:55 Sascha Zelzer [0edd8b]
Added missing virtual destructor.

[8e8003]: COMP: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceB

Merged commits:

2014-10-07 04:13:27 Sascha Zelzer [42b974]
Use mitk::IOUtil in SceneSerialization.


2014-10-07 04:12:55 Sascha Zelzer [0edd8b]
Added missing virtual destructor.

[8e8003]: COMP: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceB

Merged commits:

2014-10-07 04:13:27 Sascha Zelzer [42b974]
Use mitk::IOUtil in SceneSerialization.


2014-10-07 04:12:55 Sascha Zelzer [0edd8b]
Added missing virtual destructor.

[8e8003]: COMP: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceB

Merged commits:

2014-10-07 04:13:27 Sascha Zelzer [42b974]
Use mitk::IOUtil in SceneSerialization.


2014-10-07 04:12:55 Sascha Zelzer [0edd8b]
Added missing virtual destructor.

[dec515]: COMP: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceB

Merged commits:

2014-10-07 04:13:27 Sascha Zelzer [42b974]
Use mitk::IOUtil in SceneSerialization.


2014-10-07 04:12:55 Sascha Zelzer [0edd8b]
Added missing virtual destructor.

[99f3ec]: COMP: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceB

Merged commits:

2014-10-07 14:00:36 Sascha Zelzer [f5a169]
Added missing extensions for ITK GDCM IO.


2014-10-07 14:00:10 Sascha Zelzer [27cca2]
Disabled failing test.

[4af378]: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2

Merged commits:

2014-10-08 23:48:13 Sascha Zelzer [9fe49b]
Renamed RawImageFileReader to avoid symbol name clash with gcc < 4.5.

[8ecaa1]: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2

Merged commits:

2014-10-14 15:21:06 Sascha Zelzer [5dbc57]
Added ima and img extensions to the ITK gdcm reader.

[6fea17]: Merge branch 'bug-14866-FixingOclFilterHeader'

Merged commits:

2014-10-14 16:01:04 Thomas Kilgus [c40a32]
Removed unnecessary includes.

[fdda26]: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2

Merged commits:

2014-10-15 01:46:31 Sascha Zelzer [4de02c]
Don't use file extensions directly when matching readers.

This enables full stops in file names and file names without extensions,
as e.g. with DICOM files.

[d23bfe]: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2

Merged commits:

2014-10-15 19:41:00 Sascha Zelzer [debaa8]
Use a custom DICOM reader based.

The reader is based on the DicomSeriesReader and old DataNodeFactory code.

[ffe3dc]: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2

Merged commits:

2014-10-16 20:29:51 Sascha Zelzer [96c637]
Use correct file name encoding to support special characters.

User goch has pushed new remote branch:

bug-14866-fix-markdown-label

[857be2]: Merge branch 'bug-14866-fix-markdown-label'

Merged commits:

2014-10-20 12:44:12 Caspar Goch [be406d]
Fixed markdown label

User kislinsk has pushed new remote branch:

bug-14866-CrashOnFirstStartDueToMissingUnregisteringOfLegacyReadersAndWriters

[383ef5]: Merge branch 'bug-14866-CrashOnFirstStartDueToMissingUnregisteringOfLe

Merged commits:

2014-10-22 16:26:15 Stefan Kislinskiy [da0d4a]
Unregister legacy file readers and writers.

User zelzer has pushed new remote branch:

bug-14866-match-extensions-case-insensitive

[5d79a8]: Merge branch 'bug-14866-match-extensions-case-insensitive'

Merged commits:

2014-10-24 18:09:48 Sascha Zelzer [d9c55a]
Match extensions case insensitive.

[294960]: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2

Merged commits:

2014-10-29 20:18:27 Sascha Zelzer [5d6355]
Properly encode strings for display in the GUI.


2014-10-29 20:17:59 Sascha Zelzer [8a8185]
Enable loading of obj surface files.


2014-10-29 18:33:23 Sascha Zelzer [bd8a80]
Updated deprecatedSince version information.

[8e8598]: Merge branch 'bug-14866-MakeFileReaderAndFileWriterMicroserviceBased-2

Merged commits:

2014-11-04 08:37:13 Sascha Zelzer [59e87f]
Improved error diagnostics.

User kislinsk has pushed new remote branch:

bug-14866-RemoveLegacyIODependencies

User zelzer has pushed new remote branch:

bug-14866-reader-writer-documentation

[1a0805]: Merge branch 'bug-14866-RemoveLegacyIODependencies'

Merged commits:

2014-12-05 16:48:33 Stefan Kislinskiy [a333a2]
Merge branch 'bug-14866-RemoveLegacyIODependencies' of mitk.org:MITK into bug-14866-RemoveLegacyIODependencies


2014-12-05 16:47:52 Stefan Kislinskiy [7ec125]
Merge branch 'master' into bug-14866-RemoveLegacyIODependencies

Conflicts:
Modules/PlanarFigure/CMakeLists.txt


2014-12-03 16:17:18 Stefan Kislinskiy [292363]
Merge branch 'master' into bug-14866-RemoveLegacyIODependencies

Conflicts:
Modules/PlanarFigure/CMakeLists.txt


2014-11-06 12:02:54 Stefan Kislinskiy [1a0ff0]
Replaced DataNodeFactory usage with IOUtil::Load call.


2014-11-06 12:01:57 Stefan Kislinskiy [3b35a6]
Replaced STLFileReader usages with IOUtil::LoadSurface calls.


2014-11-06 12:00:29 Stefan Kislinskiy [6e22a5]
Replaced PointSetReader/Writer by IOUtil::LoadPointSet/Save.


2014-11-06 11:59:01 Stefan Kislinskiy [c0b206]
Removed dangling includes to deprecated header files.


2014-11-06 11:51:39 Stefan Kislinskiy [9788c1]
Removed LegacyIO dependency from IpPicSupportIO.


2014-11-06 11:48:48 Stefan Kislinskiy [9cbaab]
Removed LegacyIO dependency from PlanarFigure module.

User kislinsk has pushed new remote branch:

bug-14866-Fix1

[8e5f58]: Merge branch 'bug-14866-Fix1'

Merged commits:

2014-12-05 20:59:03 Stefan Kislinskiy [f7171c]
COMP: Removed more dependencies to LegacyIO.

[7635b9]: Merge branch 'bug-14866-Fix1'

Merged commits:

2014-12-05 21:35:01 Stefan Kislinskiy [98787f]
COMP: Made Diffusion MiniApps independent of LegacyIO.

User kislinsk has pushed new remote branch:

bug-14866-Fix2

[7bd7ed]: Merge branch 'bug-14866-Fix2'

Merged commits:

2014-12-05 21:45:00 Stefan Kislinskiy [c9709b]
COMP: Force continuous dartclients to run.

User kislinsk has pushed new remote branch:

bug-14866-Fix3

[94636d]: Merge branch 'bug-14866-Fix3'

Merged commits:

2014-12-05 22:27:11 Stefan Kislinskiy [b7a2b6]
COMP: Removed dangling include directives.

User kislinsk has pushed new remote branch:

bug-14866-Fix4

[6868ab]: Merge branch 'bug-14866-Fix4'

Merged commits:

2014-12-05 22:42:57 Stefan Kislinskiy [0cd488]
COMP: Removed even more dangling include directives.

User kislinsk has pushed new remote branch:

bug-14866-Fix5

[3e60e2]: Merge branch 'bug-14866-Fix5'

Merged commits:

2014-12-05 23:02:26 Stefan Kislinskiy [c59263]
COMP: Replaced DataNodeFactory with IOUtils.

User kislinsk has pushed new remote branch:

bug-14866-Fix6

[d2f64e]: Merge branch 'bug-14866-Fix6'

Merged commits:

2014-12-06 00:51:03 Stefan Kislinskiy [6d2209]
COMP: More LegacyIO fixes.

User kislinsk has pushed new remote branch:

bug-14866-Fix7

[02b4dc]: Merge branch 'bug-14866-Fix7'

Merged commits:

2014-12-06 01:32:34 Stefan Kislinskiy [2d7bf5]
COMP: Removed all occurrences of DataNodeFactory except in LegacyIO.

User kislinsk has pushed new remote branch:

bug-14866-RevertFixesAndRemoveLegacyIODependencies

[3231fb]: COMP: Merge branch 'bug-14866-RevertFixesAndRemoveLegacyIODependencies

Merged commits:

2014-12-06 02:41:04 Stefan Kislinskiy [ef6a55]
COMP: Revert last changes.


2014-12-06 02:16:26 Stefan Kislinskiy [4bb423]
Revert "Merge branch 'bug-14866-RemoveLegacyIODependencies'"

This reverts commit 1a08056d202ee408f529981d511cc7060aa8c06b, reversing
changes made to d9d36265b508686fed33736d2f28fd4299a00249.


2014-12-06 02:02:10 Stefan Kislinskiy [ad0bb8]
Revert "COMP: Removed more dependencies to LegacyIO."

This reverts commit f7171c84b9c326ed47f57a162276b59fc978316b.


2014-12-06 02:01:30 Stefan Kislinskiy [9cb1f8]
Revert "COMP: Made Diffusion MiniApps independent of LegacyIO."

This reverts commit 98787fdef762d3d38309a2fb38e223376e396a16.


2014-12-06 02:01:11 Stefan Kislinskiy [eafc66]
Revert "COMP: Force continuous dartclients to run."

This reverts commit c9709b3b694c0aa6687e3499e2b6302bd2508146.


2014-12-06 02:00:56 Stefan Kislinskiy [055191]
Revert "COMP: Removed dangling include directives."

This reverts commit b7a2b6431c77d43291d4d09aa1e896f6b87cfe6e.


2014-12-06 02:00:30 Stefan Kislinskiy [b57be9]
Revert "COMP: Removed even more dangling include directives."

This reverts commit 0cd4880ba492c4d19d364bb24ff450f0522651d1.


2014-12-06 02:00:16 Stefan Kislinskiy [5dc6f4]
Revert "COMP: Replaced DataNodeFactory with IOUtils."

This reverts commit c59263d6cad22d79a63be5da78422ded8b9f7164.


2014-12-06 01:59:58 Stefan Kislinskiy [3a3687]
Revert "COMP: More LegacyIO fixes."

This reverts commit 6d2209b40aa345e79a2196aa92089fad03380efd.


2014-12-06 01:59:28 Stefan Kislinskiy [f51ef7]
Revert "COMP: Removed all occurrences of DataNodeFactory except in LegacyIO."

This reverts commit 2d7bf52bf2cc62a5035d7851609eacec527bc6ff.

[172755]: Merge branch 'bug-14866-reader-writer-documentation'

Merged commits:

2014-11-27 02:56:50 Sascha Zelzer [72a8e8]
Added more reader / writer documentation.


2014-11-27 00:09:24 Sascha Zelzer [129b4e]
Merge branch 'bug-18375-cleanup-documentation-for-2014-10' into releases/2014-10

Conflicts:
Documentation/Doxygen/2-UserManual/MITKPluginManualsList.dox


2014-11-26 23:17:53 Andreas Fetzer [dc727c]
Merge branch 'bug-18391-dicom-browser-loads-data-twice' into releases/2014-10


2014-11-26 23:16:18 Andreas Fetzer [26ec59]
Changed default selected tab to import widget


2014-11-26 22:17:05 Andreas Fetzer [09e815]
Updated CTK revision

This revision contains the fix which solves the issue that data is loaded twice on double click


2014-11-26 22:12:06 Sascha Zelzer [d3e5b8]
Merge branch 'bug-18454-check-for-qt-help-capability' into releases/2014-10


2014-11-26 21:11:55 Sascha Zelzer [710d68]
Merge branch 'bug-18454-check-for-qt-help-capability' into releases/2014-10

[bb8c84]: Merge branch 'bug-14866-export-itkimageio-class'

Merged commits:

2015-02-02 13:34:24 Sascha Zelzer [bb8e13]
Make mitk::ItkImageIO part of the public API.

User zelzer has pushed new remote branch:

bug-14866-export-itkimageio-class

[4c70f8]: Merge branch 'bug-14866-export-itkimageio-class'

Merged commits:

2015-02-10 11:17:01 Sascha Zelzer [8276da]
Added missing export macro.

[dc6d5c]: Merge branch 'bug-14866-export-macro-abstractfilewriter'

Merged commits:

2015-02-17 20:36:44 Jasmin Metzger [116fab]
COMP add missing export macro

Closing this as finished.

Please open new bugs for any new issues.