Page MenuHomePhabricator

Redesign of Geometry
Closed, ResolvedPublic

Description

Redesign the Geometry to remove inheritence and make usage clearer

Event Timeline

New remote branch pushed: bug-14892-GeometryRedesign

New remote branch pushed: bug-14892-ITK4_GeometryRedesign

Added a migration guide that explains how to migrate to the new TimeGeometry concepts. :
http://www.mitk.org/Development/Refactoring%20of%20the%20Geometry%20Classes%20-%20Part%201

Prepars to commit new geometry to mitk

New remote branch pushed: bug-14892-IntegrationWithITK4

New remote branch pushed: bug-14892-Release201309-Integration

New remote branch pushed: bug-14892-MergeBranch

[f2114a]: Merge branch 'bug-14892-MergeBranch'

Merged commits:

2013-10-14 22:10:36 Michael Goetz [78c462]
Removed invalid tests


2013-10-14 22:04:09 Michael Goetz [f7d32c]
Updated wrong TimeGeometry Version


2013-10-14 21:49:03 Michael Goetz [52ede3]
Merge branch 'bug-14892-Release201309-Integration' into bug-14892-MergeBranch

Conflicts:
Plugins/org.mitk.gui.qt.registration/src/internal/QmitkRigidRegistrationView.cpp
Plugins/org.mitk.gui.qt.simulation/src/internal/QmitkCreateSimulationAction.cpp
Plugins/org.mitk.gui.qt.simulation/src/internal/QmitkSimulationView.cpp


2013-10-15 03:07:10 Michael Goetz [faca01]
Removed Wrong Test for time geometry


2013-10-10 18:34:48 Michael Goetz [ad521e]
Change deprecate messages


2013-10-10 17:12:25 Michael Goetz [8f45e6]
Changed GetNumberOfTimeSteps to CountTimeSteps


2013-10-08 21:40:36 Michael Goetz [40ebbe]
Compiling version for linux


2013-10-08 11:13:01 Michael Goetz [98d537]
Merge branch 'bug-14892-IntegrationWithITK4' into bug-14892-Release201309-Integration

Conflicts:
Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkSegmentationView.cpp


2013-09-18 11:06:44 Michael Goetz [6ebe11]
Removed TimeSlice


2013-09-10 10:55:26 Michael Goetz [88f5f5]
Added Debug Output


2013-09-09 23:16:32 Michael Goetz [0279fe]
Fixed Cloning bug in TimeGeometry


2013-09-09 22:02:18 Michael Goetz [383332]
Merge branch 'bug-14892-ITK4_GeometryRedesign' into bug-14892-IntegrationWithITK4

Conflicts:
Core/Code/DataManagement/mitkGeometry3D.cpp
Core/Code/DataManagement/mitkImage.cpp
Core/Code/IO/mitkImageWriter.cpp
Core/Code/Testing/mitkImageTest.cpp
Core/Code/files.cmake
Modules/MitkExt/Algorithms/mitkAngleCorrectByPointFilter.cpp
Modules/MitkExt/Algorithms/mitkAutoCropImageFilter.cpp
Modules/MitkExt/Algorithms/mitkSurfaceToImageFilter.cpp
Modules/MitkExt/Algorithms/mitkTimeHelper.h
Modules/MitkExt/Interactions/mitkTool.cpp
Modules/QmitkExt/QmitkFunctionalityComponents/QmitkThresholdComponent.cpp
Modules/QmitkExt/QmitkSlicesInterpolator.cpp
Modules/Segmentation/Interactions/mitkLiveWireTool2D.cpp
Modules/Segmentation/Rendering/mitkContourModelMapper3D.cpp
Plugins/org.mitk.gui.qt.diffusionimaging/src/internal/QmitkControlVisualizationPropertiesView.cpp
Plugins/org.mitk.gui.qt.diffusionimaging/src/internal/QmitkFiberfoxView.cpp


2013-07-15 10:16:49 Michael Goetz [12a204]
Changes from CodeReview


2013-07-11 14:43:47 Michael Goetz [07dd12]
Made changes suggested during the code review


2013-06-10 16:03:46 Michael Goetz [d9ea10]
TimeGeometry and Prop..TimeGeometry always return SmartPointer


2013-06-04 15:51:47 Michael Goetz [a97904]
Fixed Range bug, extended tests, complete for 3D image and pointset


2013-06-03 18:24:53 Michael Goetz [04982e]
Extended test for TimeGeometry to test more cases


2013-05-29 09:41:05 Michael Goetz [6404aa]
Updated Test


2013-05-28 11:05:18 Michael Goetz [5ce5f9]
Extended test to cover PointSet. Not finished yet.


2013-05-27 12:51:05 Michael Goetz [691870]
Added documentation and tests


2013-05-24 11:44:48 Michael Goetz [64dbdc]
Merge branch 'bug-14892-GeometryRedesign' into bug-14892-ITK4_GeometryRedesign

Conflicts:
Core/Code/Algorithms/mitkExtractSliceFilter.cpp
Core/Code/DataManagement/mitkAbstractTransformGeometry.cpp
Core/Code/DataManagement/mitkAbstractTransformGeometry.h
Core/Code/DataManagement/mitkDisplayGeometry.cpp
Core/Code/DataManagement/mitkDisplayGeometry.h
Core/Code/DataManagement/mitkGeometry2D.cpp
Core/Code/DataManagement/mitkGeometry2D.h
Core/Code/DataManagement/mitkGeometry3D.cpp
Core/Code/DataManagement/mitkGeometry3D.h
Core/Code/DataManagement/mitkLandmarkBasedCurvedGeometry.h
Core/Code/DataManagement/mitkLandmarkProjectorBasedCurvedGeometry.cpp
Core/Code/DataManagement/mitkLandmarkProjectorBasedCurvedGeometry.h
Core/Code/DataManagement/mitkPlaneGeometry.cpp
Core/Code/DataManagement/mitkPlaneGeometry.h
Core/Code/DataManagement/mitkSlicedGeometry3D.cpp
Core/Code/DataManagement/mitkSlicedGeometry3D.h
Core/Code/DataManagement/mitkThinPlateSplineCurvedGeometry.cpp
Core/Code/DataManagement/mitkThinPlateSplineCurvedGeometry.h
Core/Code/DataManagement/mitkTimeSlicedGeometry.cpp
Core/Code/DataManagement/mitkTimeSlicedGeometry.h
Core/Code/Testing/mitkTimeSlicedGeometryTest.cpp
Modules/DiffusionImaging/Quantification/IODataStructures/TbssImages/mitkNrrdTbssRoiImageReader.cpp
Modules/MitkExt/DataManagement/mitkBoundingObjectGroup.cpp
Modules/MitkExt/DataManagement/mitkExternAbstractTransformGeometry.cpp
Modules/MitkExt/DataManagement/mitkExternAbstractTransformGeometry.h
Modules/MitkExt/Interactions/mitkTool.cpp
Modules/QmitkExt/QmitkFunctionalityComponents/QmitkThresholdComponent.cpp
Modules/Segmentation/Algorithms/mitkCorrectorAlgorithm.cpp
Plugins/org.mitk.gui.qt.registration/src/internal/QmitkPointBasedRegistrationView.cpp
Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkSegmentationView.cpp
Plugins/org.mitk.gui.qt.simulation/src/internal/QmitkSimulationView.cpp
Plugins/org.mitk.gui.qt.tofutil/src/internal/QmitkToFUtilView.cpp


2013-05-23 16:20:11 Michael Goetz [bf5d85]
Added test for TimeGeometry. Partly finished


2013-05-03 11:46:34 Michael Goetz [fc2208]
Fixed missing Print.

Caused a undetailed information dialog.


2013-05-03 11:14:17 Michael Goetz [2a2bd0]
Fixed bug that SlicerPosition is not updated.


2013-05-02 19:45:30 Michael Goetz [c2a999]
Removed references to AffineGeometryFrame3D


2013-05-02 19:41:26 Michael Goetz [ddd721]
Removed AffineGeometryFrame3D Inheritance from Geometry3D


2013-04-30 18:28:12 Michael Goetz [8cc1e8]
Updated documentation for geometry


2013-04-30 15:21:42 Michael Goetz [cea713]
Removed TimeSlicedGeometry complete


2013-04-30 15:07:09 Michael Goetz [fb4c48]
Removed TimeSlice from additional classes

Working and compiling version, testes
Diffusion Gibbs Tracking, Fibers
Image Cropper


2013-04-30 14:08:15 Michael Goetz [5acdbc]
Removed TimeSlicedGeometry from several files


2013-04-30 12:56:50 Michael Goetz [2f5c11]
Removed TimeSlicedGeometry from diffusion


2013-04-30 10:46:14 Michael Goetz [97ddfe]
Removed TimeSlicedGeometry from PlaneFit-Filter


2013-04-29 23:30:53 Michael Goetz [d5f06d]
Fixed Problem with TimeSlicer introduced by previous commit


2013-04-29 23:19:32 Michael Goetz [aeefd2]
Fixed Problem with Image initialisation using non-sliced geometry3d


2013-04-29 22:29:04 Michael Goetz [12d54b]
Fixed PlanarFigure

Detected by PlanarFigureIOTest, Geometry2D was not saved
because no smartpointer was used


2013-04-29 21:59:56 Michael Goetz [aff57a]
Fixed ipPicTest

Removed unsupported feature


2013-04-29 21:42:45 Michael Goetz [bc6808]
Fixed Test problem with ImageReaderTest

Problem was caused by wrong MTime due to calculations
during BoundingBoxUpdate


2013-04-25 15:35:09 Michael Goetz [e17447]
Core Working Version for Debug and Release.

Woring Version without any plug-ins,
still some TimeSlicedGeometrys in Code
Debug and Release are working


2013-04-25 14:10:32 Michael Goetz [d8aaed]
Fixed some VtkRenderingTests


2013-04-23 15:16:30 Michael Goetz [b10fbe]
Fixed SliceNavigationControllTest and ImageTest

Problem was due to Initialisation of images


2013-04-23 09:12:41 Michael Goetz [b990dc]
Fixed error in TimeGeometry

(Smartpointer-Issue)


2013-04-22 17:17:01 Michael Goetz [dc1a7d]
Removed TimeSlicedGeometry from CoreTests

Except in Test for TimeSlicedGeometry


2013-04-22 17:08:41 Michael Goetz [07ae86]
Removed TimeSlicedGeometry from all classes in Core/Datamanagement

Except TimeSlicedGeometry which remains for compatibilty reasons


2013-04-22 15:31:48 Michael Goetz [d3c6d6]
Fully removed TimeSlicedGeometry from BaseData

Version is compiling but not starting


2013-04-22 13:34:18 Michael Goetz [c61abd]
Compiling Version after transfered SliceNavigationController and
RenderingManager


2013-04-19 14:08:04 Michael Goetz [3d7eda]
Replaced GetTimeSlicedGeometry and GetUpdatedTimeSlicedGeometry


2013-04-18 10:25:24 Michael Goetz [5e439b]
Compiling Vesion without static GetTimeSlicedGeometry


2013-04-15 14:18:30 Michael Goetz [4e8b46]
Added comments to TimeGeometry anded it to BaseData


2013-04-05 21:39:07 Michael Goetz [a96eb6]
Added first BaseGeometry. Contains mainly a old Geometry3D


2013-04-05 20:38:28 Michael Goetz [48be12]
Added first version of TimeGeometry

New remote branch pushed: bug-14892-COMPFix1

[05b4b1]: Merge branch 'bug-14892-COMPFix1'

Merged commits:

2013-10-15 00:09:12 Michael Goetz [14220d]
COMP: Fixed wrong call in Examples

New remote branch pushed: bug-14892-EnhancePrintSelfOfProportionalTimeGeometry

[8ba953]: Merge branch 'bug-14892-EnhancePrintSelfOfProportionalTimeGeometry'

Merged commits:

2013-10-16 14:45:56 Christoph Kolb [ee2507]
added FirstTimePoint and StepDuration to PrintSelf Method

New remote branch pushed: bug-14892-FixInvalidPropTimeInit

[7de210]: Merge branch 'bug-14892-FixInvalidPropTimeInit'

Merged commits:

2013-10-16 15:40:20 Michael Goetz [3bed84]
Fixed invalid ProportionalTimeGeometry::Initialize()

Initialize() has not reset the number of contained time steps