Page MenuHomePhabricator

Compile error on GCC 4.7 / Fedora 18
Closed, ResolvedPublic

Description

I ran into a compiler option problem caused by a C file in the c++ micro services. I do not understand why this was not detected by the dartclient on mbi089.

I will fix it by setting two C++-only options only for C++ files.

Event Timeline

[bcee6b]: Merge branch 'bug-15003-cpp-only-flags'

Merged commits:

2013-04-20 13:29:44 Marco Nolden [329242]
COMP: correctly set some C++-only compiler options

This is related to bugs #14937 and #14883.

The problem is not our CMake code but with the scripts shipped with CMake itself which do not correctly detect error/warning messages from the compiler that it doesn't know about a certain flag. After fixing the other two bugs in a generic way, I would actually like to revert your changes.

Ok, I agree. I did not check the implementation of "mitkFunctionCheckCompilerFlags2" , maybe we could rename it to
"mitkFunctionCheckCompilerFlagsCAndCPlusPlus" , or something better ...

As I wrote in T15003 comment 3 this is also related to the system locale, that's probably the reason why my otherwise identical system in the office does not fail on compile.

(In reply to comment #3)

As I wrote in T15003 comment 3 this is also related to the system locale,
that's probably the reason why my otherwise identical system in the office
does not fail on compile.

wrong link: T14937 comment 3