Page MenuHomePhabricator

mitk::SerialCommunication is missing standard baud rates greater than 115200
Closed, ResolvedPublic

Description

/usr/include/bits/termios.h defines:

#define B230400 0010003
#define B460800 0010004
#define B500000 0010005
#define B576000 0010006
#define B921600 0010007
#define B1000000 0010010
#define B1152000 0010011
#define B1500000 0010012
#define B2000000 0010013
#define B2500000 0010014
#define B3000000 0010015
#define B3500000 0010016
#define B4000000 0010017

But they are not usable via the mitk::SerialCommunication::SetBuadRate interface.

Event Timeline

Pull request: https://github.com/MITK/MITK/pull/26

Note: I have only tested baud rate 3000000 and only on Linux.

New remote branch pushed: bug-15911-AddMissingBaudRates

Changes are tested with various systems and work flawlessly. I added another baud rate and some documentation. Alfred, you said you were going to manage merging IGT pull requests, so I'm assigning this back to you.

Most of the new baud rates are not supported by MAC_OS - at least not in the same way as in Linux. See http://cdash.mitk.org/viewBuildError.php?buildid=368991 for more details.

I will try to add a special case for MAC_OS where these baud rates are excluded.

New remote branch pushed: bug-15911-BaudRateProblemsOnMacOS

[6bca68]: Merge branch 'bug-15911-BaudRateProblemsOnMacOS'

Merged commits:

2013-11-06 20:41:21 Alfred Franz [7b062f]
COMP(#15911): Commented out the baud rates which are not working on Mac OS for the moment

Commented out the baud rates which are not working for the moment.

We still have to test and fix this on Mac OS. I don't have a Mac OS system available at the moment.

New remote branch pushed: bug-15911-FixMacBaudRatesForSerialCommunication

[d70a31]: Merge branch 'bug-15911-FixMacBaudRatesForSerialCommunication'

Merged commits:

2014-01-16 14:14:31 Andreas Fetzer [9b3b3d]
Fixed build error on mac.


2014-01-15 16:56:25 Keno Maerz [5fcefa]
Fixed missing comment in Posix part and removed questionable Baudrate


2014-01-15 16:28:33 Keno Maerz [bcb630]
Uncluttered Serial Communication and added new ifdef structure for platform specific code