Page MenuHomePhabricator

Decide what to do with mitkItkNonUniformBSpline.
Closed, WontfixPublic

Description

The class mitkItkNonUniformBSpline was taken from an earlier ITK version (concering to file ITK 1.8) and slightly modified. The current master verion in ITK 4.3 itkNonUniformBSpline is deprecated. Currently, the mitkItkNonUniformBSpline is only used inside the virtual tracking device.

During the IGT-Hackfest there was a task to delete it, which was not possible due to major dependencies of the virtual tracking device.
If we want to remove this mitkItkNonUniformBSpline class, we have to re-implement the virtual tracking device and most of its functions.

This bug written by Thomas Kilgus with Alfreds Account.

Event Timeline

franza added a subscriber: franza.Oct 9 2013, 1:54 PM

We have to check if the mitkItkNonUniformBSpline contains patented code, which might be the reason why it was removed from ITK. If yes we have to remove it as soon as possible and this bug has very high priority.

If not, we can leave it as it is for the moment and remove this class later.

However: this class should be declared deprecated either way!

franza added a comment.Oct 9 2013, 2:42 PM

Also have a look on the comments of T3454 for more information!

franza added a comment.Oct 9 2013, 2:45 PM

Concerning a reimplementation of the virtual tracking device T2176 might also be of interest!

neuhaus added a subscriber: neuhaus.Oct 9 2013, 3:21 PM

(In reply to Alfred Franz from comment #1)

We have to check if the mitkItkNonUniformBSpline contains patented code,
which might be the reason why it was removed from ITK. If yes we have to
remove it as soon as possible and this bug has very high priority.

If not, we can leave it as it is for the moment and remove this class later.

However: this class should be declared deprecated either way!

As you can see in the ITK bug tracker linked in T3454, they removed the class because no one wanted to fix a small compilation error (which was never detected because the class was not used in ITK), not because of patented code.

So, if there is no issue with patenting, there is no need to remove this class at the moment. So setting the importance to low. However, refactoring of the virtual tracking device as discussed in T3454 might be a task for the future.

kislinsk reopened this task as Open.Jun 27 2018, 1:04 PM
kislinsk added a project: Bulk Edit.
kislinsk closed this task as Wontfix.Jun 27 2018, 1:09 PM
kislinsk removed a project: Bulk Edit.