Page MenuHomePhabricator
Create Task
Maniphest T16339

Lot of generated warnings with clang due to Wunused-parameter
Closed, ResolvedPublic
Actions

Description

The implementation of the

mitk::Image::Initialize( pixeltype, tsg, ch, t )

method was removed during the geometry refactoring ( we have no TimeSlicedGeometry more ) but the method remains in API as deprecated with an empty implementation for compatibility reasons. Hence every single include of the mitkImage.h file generates a warning ( up to 30k when compiling with clang ).

Solution:

Remove the parameter names.

Event Timeline

• hering added projects: MITK, Bugzilla.Oct 28 2013, 3:48 PM
• hering added a comment.Oct 28 2013, 3:58 PM

New remote branch pushed: bug-16339-WarningStorm

• hering added a comment.Oct 28 2013, 4:12 PM

[7be47d]: Merge branch 'bug-16339-WarningStorm'

Merged commits:

2013-10-28 15:57:25 Jan Hering [9c0329]
Removed named parameters from deprecated method

  • avoids a plenty of Wunused-parameter warnings
• hering added a comment.Oct 29 2013, 11:35 AM

There is also a empty-implementation method ReleaseGraphicsResources in mitkVtkMapper.h with named parameter. Same fix ( = same bug )

• hering added a comment.Oct 29 2013, 11:36 AM

[b5d172]: Merge branch 'bug-16339-WarningStorm'

Merged commits:

2013-10-29 11:35:58 Jan Hering [d83087]
Removed named parameter in empty-implementation method

• hering added a comment.Jan 21 2015, 2:46 PM

The issue is still active, affected class header : mitkGeometry3D.h

• hering added a comment.Jan 21 2015, 3:00 PM

To be fixed:

	modified:   Core/Code/DataManagement/mitkBaseGeometry.h

modified: Core/Code/DataManagement/mitkGeometry3D.h
modified: Core/Code/DataManagement/mitkPlaneGeometry.h
modified: Core/Code/DataManagement/mitkSlicedGeometry3D.h

• hering added a comment.Jan 21 2015, 3:03 PM

[3e6a78]: Merge branch 'bug-16339-GeometryClass-Warning-Storm'

Merged commits:

2015-01-21 14:54:10 Jan Hering [5c95b8]
Removed unused parameter in virtual methods

  • methods are provided with empty implementation
kislinsk closed this task as Resolved.Dec 22 2017, 12:45 AM
kislinsk claimed this task.
kislinsk added a subscriber: • hering.
MITK · MIC · IMSY · DKFZ