Page MenuHomePhabricator

PlanarFigure not always editable when rendered
Closed, ResolvedPublic

Description

Both the PlanarFigureInteractor and the PlanarFigureMapper check if the current Rendering-Geometry is near enough to the PlanarFigureGeometry and do nothing if the geomtries are not close to each other.

The two classes do not use the same tolerance here which can lead to situations in which the rendering-geometry is close enough for rendering (PF is drawn) but too far away for interaction (although interaction should be possible).

The solution would be to use the same tolerance in both the mapper and the interactor to make sure that a PlanarFigure that is rendered is actually editable.

Event Timeline

engelm added a subscriber: engelm.

New remote branch pushed: bug-16449-planarFigureInteractor-correct-tollerance

New remote branch pushed: bug-16449-correct-planarfigureinteractor-tolerance-master

I adapted the distance-tolerance of the interactor to match that of the mapper. Thus a PlanarFigure that is rendered is also editable by the interactor.

Is this bug relevant for the release? Its status is fixed but you requested a release flag :)

This issue is present in the current version.

I was able to reproduce it by creating a PlanarFigure on an image with a slice-thickness of 4mm and performing a reinit on another image in the same scene with a slice-thickness of 2mm.

I could see the PlanarFigure on the correct slice but was not able to interact with it.

I fixed the bug and wanted to integrate the changes into master. Only then did I realize that you are currently in the release phase. Up to you if you want to include the fix.. =)

[04b173]: Merge branch 'bug-16449-correct-planarfigureinteractor-tolerance-maste

Merged commits:

2013-11-19 13:30:04 Markus Engel [165073]
using the same tolerance as the PF-Mapper in the PF-Interactor