Page MenuHomePhabricator

Function to block signals from slice navigation controller
Closed, WontfixPublic

Description

There should be a way to block signals from mitk::SliceNavigationController.

We have a custom viewer based on QmitkStdMultiWidget. The logic of changing the window layout or the geometry is more complex than that of the original QmitkStdMultiWidget. It involves construction a geometry for the slice navigation controllers, setting their positions, etc.

Currently, several events are generated during this process, which results that other plugins who listen to the slice change events, get notified about slice changes when the viewer is in an inconsistent state, because the geometry is being set at the moment.

The solution would be to block the signals of the SNCs while the geometry is being set, and send out the notifications when the viewer is in a consistent state again.

I am going to propose a patch through a github pull request.

Event Timeline

https://github.com/MITK/MITK/pull/44

Note that I also corrected a little mistake in the code:
I removed line 329 and 336 because they were in conflict with line 221 and 351.

Any opinion about this?
Can it be merged, or should it stay on our fork?

kislinsk claimed this task.
kislinsk added a project: Auto-closed.
kislinsk added a subscriber: kislinsk.

Hi there! 🙂

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. 🚑

Best wishes,
The MITK devs

kislinsk removed kislinsk as the assignee of this task.May 26 2020, 12:05 PM
kislinsk removed a subscriber: kislinsk.