Page MenuHomePhabricator
Create Task
Maniphest T17190

PlanarFigureInteractor unnecessarily uses property of PlanarFigure
Closed, ResolvedPublic
Actions

Description

The 'new version' of the PlanarFigureInteractor uses the property "initiallyplaced" to determine if the figure has been placed or not in the method CheckFigurePlaced().

This check has been introduced in the porting of the PlanarFigureInteractor to the new interaction-framework.

This check is not necessary and causes massive problems with the interaction of PlanarFigures that have been serialized BEFORE the property "initiallyplaced" has been introduced.

As this check is unnecessary, we can remove the check without a problem.

Related Objects

Event Timeline

engelm added projects: MITK, Bugzilla.Feb 13 2014, 11:59 AM
• git-user added a subscriber: • git-user.Feb 13 2014, 12:00 PM

User engelm has pushed new remote branch:

bug-17190-planarfigureinteraction-with-old-figures-snapshot
• git-user added a comment.Feb 13 2014, 12:03 PM

User engelm has pushed new remote branch:

bug-17190-planarfigureinteraction-with-old-figures
engelm added a subscriber: engelm.Feb 13 2014, 12:09 PM

I have removed the check for the property as described in the description. Interaction with PlanarFgigures that have been serialized without the property "initallyplaced" works fien again.

Merge to master is currently not possible due to a red dashboard.

engelm added a comment.Feb 21 2014, 1:00 PM

OK, turns out we really need the check for this property here. Without it, the PlanarFigure is not correctly created when moving the mouse even slightly during a double-click.

engelm added a comment.Feb 24 2014, 8:35 AM

[510c65]: Merge branch 'bug-17190-planarfigureinteraction-with-old-figures'

Merged commits:

2014-02-24 08:28:23 Markus Engel [3e07d1]
fixed additional interaction bug in PlanarFigureInteractor

2014-02-21 13:01:05 Markus Engel [7d7cd5]
adding missing property in PlanarFigureReader

2014-02-21 13:01:30 Markus Engel [c70c6b]
Revert "removed unnecessary check for property "initiallyplaced""

This reverts commit d8b96002545e0fbe2128f0858dfbb2e6fc979c1f.

2014-02-13 12:00:06 Markus Engel [91a1be]
removed unnecessary check for property "initiallyplaced"

engelm added a comment.Feb 24 2014, 9:17 AM

[1c0765]: COMP: Merge branch 'bug-17190-planarfigureinteraction-with-old-figures

Merged commits:

2014-02-24 09:15:13 Markus Engel [12aac5]
added missing property to fix PlanarFigureIOTest

kislinsk added a subscriber: kislinsk.Mar 19 2014, 4:22 PM

@Markus
What's the status?

engelm added a comment.Mar 19 2014, 5:21 PM

Works like a charm. The fix has not been closed because I was not able to integrate it into master yet (Dashboard locked).

I admit I haven't tried to merge it recently, but it should not be a problem.. Can you give it a try?

• fetzer added a subscriber: • fetzer.Mar 26 2014, 12:08 PM

Markus, what is the status of this bug? Is it safe to include it into the upcoming release?

engelm added a comment.Mar 26 2014, 12:13 PM

Yes, it's safe. There really should be no issues connected to these changes..

• fetzer added a comment.Apr 11 2014, 3:32 PM

Current release is finished. Resetting target milestone

kislinsk mentioned this in T27033: Clean up stale remote branches.Jan 25 2020, 9:01 PM
MITK · MIC · IMSY · DKFZ