User franza has pushed new remote branch:

bug-17303-NavigationToolStorageDeserializer

User franza has pushed new remote branch:

bug-17303-NavigationToolStorageDeserializerV2

[c4652b]: Merge branch 'bug-17303-NavigationToolStorageDeserializerV2'

Merged commits:

2014-02-21 11:03:32 Alfred Franz [f6f063]
COMP(#17303): disabled tests because of T17181 and T17303

2014-02-21 11:00:29 Alfred Franz [2354a4]
Merge branch 'bug-17303-NavigationToolStorageDeserializer' into bug-17303-NavigationToolStorageDeserializerV2

2014-02-21 10:56:14 Alfred Franz [0e5bb4]
COMP(#17303): Started conversion of deserialzer to IOUtil, not working yet

[d6c691]: Merge branch 'bug-17303-NavigationToolStorageDeserializer'

Merged commits:

2014-02-21 18:37:51 Alfred Franz [3268af]
now using the mitk program path to permanently store the toolfiles. Maybe this helps to avoid errors.

2014-02-21 18:21:45 Alfred Franz [a52373]
replaced call of CreateTemporaryDirectory() by call with parameters, so it is not affected by T17310

2014-02-21 17:21:23 Alfred Franz [e2bddc]
replaced dirty hack by poco implementation

merged all the fixes.

still TODO: activate the test again!

Failed again :-(

http://cdash.mitk.org/testDetails.php?test=8197870&build=445100

By the way, not only the continuoud dart client has the problem but also the user of an installed application!

I just found out that a crash a user reported is caused by the same bug. The NavigationToolStorage tries to serialize the storage and crashes during serialization. The user can proceed after confirming an error box telling to manually save the data and shut down the system. During the next startup the application crashes when starting the plugin.

The NavigationToolStorage is supposed to be stored in the cache directory, right?

I won't open up another bug as this it would be basically the same as this bug.

Cheers ;)
Ingmar

This bug was also upvoted by @clarkson on our mailing list today. I raised the priority to Unbreak Now!.

Hi Alfred.

I think its this line of code:

https://github.com/MITK/MITK/blob/master/Modules/IGT/IO/mitkNavigationToolStorageDeserializer.cpp#L39

We create our app, create an installer using nsis, and install it on another machine. The default installation dir is therefore under C:\Program Files, which is only writable by the Administrator.

So, when a non-priviledged user runs the app, this deserialisation code tries to create a temporary file under C:\Program Files rather than under C:\Temp.

So it should be

mitk::IOUtil::GetTempPath()

instead of

mitk::IOUtil::GetProgramPath()

Thanks

Matt

Hi Matt,

thanks for this hint. It should be easy to change but is possibly not the reason for the original bug which occured randomly on our dart clients.

Regards,

Alfred

Did it work?

I don't know yet. We are still working on the phabricator migration and the continuous clients are not fully functional at the moment. On my PC the test works fine. But the problem was a random fail that appeared on the continuous client once a week or less, so we have to wait to see if it happens again.

Did you check if the fix solves your problem?

Steve Thompson, here at UCL, just tested it, and reported that it does appear to fix our problem. Thanks.

Any news on this?