Page MenuHomePhabricator
Create Task
Maniphest T17376

Visual Studio 2013 compatibility
Closed, ResolvedPublic
Actions

Description

There are some small issues when compiling with Visual Studion 2013 (mostly std::min,max requiring explicit <algorithm> include and ostringstream not being able to be output into other stream directly).

Related Objects
Search...

Event Timeline

khlebnikov added projects: MITK, Bugzilla.Feb 28 2014, 3:02 PM
khlebnikov added a subscriber: khlebnikov.Feb 28 2014, 3:38 PM

Pull request submitted: https://github.com/MITK/MITK/pull/47

Visual Studion 2013 Update 1, x64

Superbuild options differing from defaults:

External packages:
VTK 6.0.0
ITK 4.4.2
CTK SHA-1 4cfeaaf79e54dba8ed73fab1d15fad36bffd209d (current head)
GDCM 2.4.1
Qt 4.8.5.

BUILD_TESTING : OFF

MITK build options differing from defaults:

MITK_BUILD_org.mitk.gui.qt.basicimageprocessing : ON
MITK_BUILD_org.mitk.gui.qt.properties : ON
MITK_BUILD_org.mitk.gui.qt.segmentation : ON
MITK_BUILD_org.mitk.gui.qt.volumevisualization: ON
MITK_BUILD_org.mitk.planarfigure : ON

nolden added a subscriber: nolden.Mar 11 2014, 1:22 PM

Thanks. I will try to get this into the upcoming 2014.03 release. Did you experience any issues with GDCM 2.4.1? Did you test any DICOM functionality?

khlebnikov added a comment.Mar 11 2014, 1:55 PM

Hi Marco,

I didn't try any DICOM functionality for now. There were no compilation issues though.

Rostislav.

khlebnikov added a comment.Mar 11 2014, 4:31 PM

I have successfully imported a local directory with the DICOM editor - if this works as any kind of DICOM functionality test.

nolden added a comment.Mar 11 2014, 6:07 PM

(In reply to Rostislav Khlebnikov from comment #4)

I have successfully imported a local directory with the DICOM editor - if
this works as any kind of DICOM functionality test.

Thanks. The DICOM editor is primarily using DCMTK. We will probably update to GDCM 2.4 soon and then include this in our release testing for MITK 2014.03

nolden added a comment.Mar 18 2014, 1:29 PM

Core flag for trivial compilation fixes

nolden added a comment.Mar 18 2014, 1:31 PM

[9c3081]: Merge branch 'bug-17376-vs1013-compatibility'

Merged commits:

2014-03-18 13:23:57 Marco Nolden [5fe753]
Merge branch 'bug-17533-update-gdcm24' into bug-17376-vs1013-compatibility

2014-03-18 13:27:20 Marco Nolden [abcb85]
Update superbuild to GDCM 2.4.1

2014-03-18 13:00:06 Marco Nolden [2ca0ee]
Compilation fix for VTK 6.0

2014-03-18 13:11:53 Rostislav Khlebnikov [4f4cc1]
VS2013 compilation fixes

nolden added a comment.Mar 30 2014, 4:16 PM

A few findings with VS2013 and Qt5 on windows:

  • the Qt 5.2.1 installer _with_ OpenGL fails to find glut32. A possible workaround is to use the non OpenGL version, I still have to check if it really works
  • Qwt and VTK's Qt support are not disabled properly and cause problems
  • a pure VS 2013 install does not include the VS 2012 redistributables. "moc" from the binary Qt distribution fails to run without it
• git-user added a subscriber: • git-user.Apr 2 2014, 3:09 PM

User nolden has pushed new remote branch:

bug-17376-visual-studio-2013-compatibility
nolden added a comment.Apr 2 2014, 3:10 PM

[b74517]: Merge branch 'bug-17376-visual-studio-2013-compatibility'

Merged commits:

2014-04-02 15:08:21 Marco Nolden [75d802]
Ignore heap alignment warning from VS2013

kislinsk added a subscriber: kislinsk.Oct 16 2014, 2:09 PM

Regarding the Qt5 OpenGL build issue (glut32 not found): You have to add the Windows Kit library directory to CMAKE_PREFIX_PATH, e.g.:

C:\Program Files (x86)\Windows Kits\8.0\Lib\win8\um\x64

MITK · MIC · IMSY · DKFZ