Github pull request: https://github.com/MITK/MITK/pull/49

Just checking on status of this bug. Have there been any issues getting the pull request merged? I'm hoping the upgrade is transparent for all Qt4-based code.

Also, I just rebased the pull request against a recent fetch from master and re-updated against the latest qtsingleapplication from the qt-solutions repository.

Thanks for picking this up again.

The reason for not having it merged yet is that we (I) didn't find the time yet to test it with both Qt4 and Qt5. Did you try to build both?

I've tested with Qt5, but not Qt4. I can test with Qt4, but I figured it would be easier for you since that's your standard development environment (I think?).

Yes, I just wanted to avoid redundant work. And I had a feeling that there might be a hidden issue...

Indeed, we did patch the original qtsingleapplication sources (which was not obvious by just looking at the source code folder). I had to do that again and added the changes as a separate patch file.

Is that patch something general enough to be contributed to qtsolutions?

User zelzer has pushed new remote branch:

bug-17529-Upgrade-qtsingleapplication

[c3a606]: Merge branch 'bug-17529-Upgrade-qtsingleapplication'

Merged commits:

2014-09-10 18:42:06 Sascha Zelzer [ad09f3]
Use Qt5 QTemporaryDir class instead of custom Qt4 code.

2014-09-10 17:56:27 Sascha Zelzer [e95ba2]
Added qtsingleapplication customizations again on top of updated files.

2014-09-10 18:33:33 Sascha Zelzer [13dcc7]
Update to latest version of qtsingleapplication for Qt5 support

Signed-off-by: Taylor Braun-Jones <taylor.braun-jones@ge.com>

The patch just uses QByteArray instead of QString for passing data between processes. This was just convenience for us for serializing/deserialing Qt types. It wasn't something considered as generally useful so we did not try to merge it upstream.

Another note: I had to amend your commit due to trailing white spaces which were rejected by our server side git hooks. So unfortunately your author information is lost (except for the sign-off).

Great, thanks for merging! I'll make sure to re-enable the MITK pre-commit hook that I had meant to just temporarily disable.

[d3570c]: Merge branch 'bug-17529-Upgrade-qtsingleapplication'

Merged commits:

2014-09-10 20:07:31 Sascha Zelzer [bad4b3]
COMP: Correct Windows type conversions for strings.