Page MenuHomePhabricator

Render window frames are rendered stippled in certain cases
Closed, ResolvedPublic

Description

Martin Klemm discovered a bug regarding the rendering of render window frames. He wrote on the MITK users list:

I am rendering
a pointer (yellow part) and a blue line. This line is stippled. The
problem is that now with the below modifications it shows the frame of
the render window also stippled. I also removed the modifications and
tried the manual way in the GUI. The frame is just stippled when the
crosshair is hidden.

This is the code I use in ApplyAllProperties of my line mapper:
bool isStippled = false;

int stipplePattern;
node->GetBoolProperty("stippled", isStippled);
if ( isStippled )
{
   stipplePattern = 0xff00;
}
else
{
   stipplePattern = 0xffff;
}
_actor->GetProperty()->SetLineStipplePattern(stipplePattern);

renderWindowFrameStippled.jpg (1×1 px, 68 KB)

Event Timeline

Can be easily fixed by ensuring that GL_LINE_STIPPLE is disabled in vtkMitkRectangleProp::RenderOverlay():

glDisable(GL_LINE_STIPPLE);

User kislinsk has pushed new remote branch:

bug-17572-EnsureRanderWindowFrameLineIsNotStippled

[e0e868]: Merge branch 'bug-17572-EnsureRanderWindowFrameLineIsNotStippled'

Merged commits:

2014-03-26 17:32:50 Stefan Kislinskiy [5e989d]
Disable GL_LINE_STIPPLED when rendering render window frames.