Page MenuHomePhabricator

Live Wire Tool: Various flaws
Closed, ResolvedPublic

Description

Helper objects are global and remain even if tool is deactivated or segmentation is deleted (see also T17661). Reinit necessary because of global objects.

Tool only works for one render window (first one which was used).

Tool cannot be cancelled, neither by deactivating the tool (contour is further drawn in last state) nor by a "Discard segmentation" button.

Event Timeline

User kislinsk has pushed new remote branch:

bug-17668-LiveWireTool

Made helper objects local to working image and cleaned up code a little bit.

TODO: Warn user about deletion of unconfirmed contours when deactivating the tool. How can we intercept tool deactivation?

TODO: Handle case where working image is changed during active tool. We need to be notified about this event and handle appropriately.

User kislinsk has pushed new remote branch:

bug-17668-LiveWireTool2

Fixed all issues except change of working images during active tool which is a general problem of our tool concept and needs overhauling after the release.

AWAITING RELEASE FLAG <<

Caution: Use bug-17668-LiveWireTool2 branch instead of bug-17668-LiveWireTool branch.

[eea229]: Merge branch 'bug-17668-LiveWireTool2'

Merged commits:

2014-04-09 11:51:35 Andreas Fetzer [f77124]
Added missing rendering update


2014-04-03 14:55:32 Stefan Kislinskiy [c5c707]
Merge branch 'bug-17668-LiveWireTool' into bug-17668-LiveWireTool2


2014-04-03 14:53:43 Stefan Kislinskiy [1f70f6]
Contours can be cleared. Segmentation is confirmed on tool deactivation.


2014-04-02 19:04:24 Stefan Kislinskiy [2498d1]
Made helper objects local to working image.

Is there anything left to do or can we close this bug?