Page MenuHomePhabricator

DICOMITKSeriesGDCMReader sorts wrong when number of digits varies
Closed, WontfixPublic

Description

The DICOMITKSeriesGDCMReader has a list of DICOM Tags that are used to distinguish whether two DICOM images can be attributed to the same mitk::Image or not.

However, this code needs the tags to be absolutely identical as no numerical comparison is performed (only string based). In my case, this is a problem because one image has a slice-thickness of 4 and the neighbouring slice has a slice-thickness of 4.00000. In the current implementation, these DICOM images do not end up in the same mitk::Image.

The fix is quite simple, as a similar fix has already been implemented for the Tag 'Image Orientation'.

Event Timeline

User engelm has pushed new remote branch:

bug-17976-numerical-compare-dicom-tags

User engelm has pushed new remote branch:

bug-17976-make-sorting-independent-of-number-of-digits

[2681f6]: Merge branch 'bug-17976-make-sorting-independent-of-number-of-digits'

Merged commits:

2015-10-28 08:49:40 Markus Engel [fcab88]
improved const-correctness and fixed typos


2015-10-28 08:49:15 Markus Engel [aa5814]
using itkFactorylessNewMacro


2015-10-28 08:48:51 Markus Engel [61fccd]
numerical dicom tags are handled numerically

[6c1576]: COMP: Merge branch 'bug-17976-make-sorting-independent-of-number-of-di

Merged commits:

2015-10-30 09:36:44 Markus Engel [5d253a]
Revert "numerical dicom tags are handled numerically"

This reverts commit 61fccd4e3a74a42a2d4325afd2c7cf3224dcf5df.

kislinsk added a subscriber: kislinsk.
This task was automatically closed because it wasn't updated at least since July 2016 (over 2 years). Please re-open this task if you think that it is still relevant. This most probably means that you will resolve it.