Page MenuHomePhabricator

mitk::ManufacturerLogo::Middle does not show anything
Closed, ResolvedPublic

Description

The code

newPos[0] = 0.5 - 0.2 * normX * m_ZoomFactor;
newPos[1] = 0.5 + 0.2 * normY * m_ZoomFactor;
newPos[2] = 0.5 - 0.2 * normX * m_ZoomFactor;
newPos[3] = 0.5 + 0.2 * normY * m_ZoomFactor;

makes no sense when describing the lower left and upper right points of the viewport.

The correct way of calculating this for a middle position is:

newPos[0] = 0.5 - 0.1 * normX * m_ZoomFactor;
newPos[1] = 0.5 - 0.1 * normY * m_ZoomFactor;
newPos[2] = 0.5 + 0.1 * normX * m_ZoomFactor;
newPos[3] = 0.5 + 0.1 * normY * m_ZoomFactor;

Event Timeline

@Christoph, could you have a look at this on Wednesday?

User kolbch has pushed new remote branch:

bug-18814-MiddlePositionInManufacturerLogo

i have inserted your calculation in the ManufacturerLogo, but I would recommend using the mitk::LogoOverlay instead, because the ManufacturerLogo will soon be deprecated.
the LogoOverlay now has also a middle position.

[6b5cf1]: Merge branch 'bug-18814-MiddlePositionInManufacturerLogo'

Merged commits:

2015-03-11 20:25:27 Christoph Kolb [3c755b]
add middle position to logooverlay


2015-03-11 20:25:09 Christoph Kolb [f13419]
deprecate manufacturerlogo


2015-03-11 18:22:32 Christoph Kolb [915e6e]
remove unused widget in logooverlay and fix middle position in ManufacturerLogo