Page MenuHomePhabricator
Create Task
Maniphest T18883

warnings interpreted as error with clang 3.6
Closed, InvalidPublic
Actions

Description

Clang 3.6 creates a warning if the override keyword is missing. This should maybe not be interpreted as an error yet.

add
mitkFunctionCheckCAndCXXCompilerFlags("-Wno-error=inconsistent-missing-override" module_c_flags module_cxx_flags)
to
/home/christoph/data/dartclients/clang-mitk-debug/MITK/CMake/mitkFunctionCreateModule.cmake

Related Objects

Event Timeline

• kolbch added projects: MITK, Bugzilla.Mar 24 2015, 11:16 AM
zelzer added a subscriber: zelzer.Apr 1 2015, 8:58 PM

Marco is looking into transforming the source code accordingly.

• kolbch added a subscriber: • kolbch.May 18 2015, 3:46 PM

unused typedefs are also creating a warning / error in clang 3.6

• git-user added a subscriber: • git-user.May 18 2015, 4:00 PM

User kolbch has pushed new remote branch:

bug-18883-Clang360CompatibilityFix
• kolbch added a comment.May 18 2015, 4:02 PM

core change required.
only removed unused typedefs. compiling with clang 3.6 works

• kolbch added a comment.May 19 2015, 11:33 AM

The warnings are gone... I don't know why

nolden added a subscriber: nolden.May 20 2015, 1:36 PM

Decided to merge this anyway since it is a useful fix

• kolbch added a comment.May 20 2015, 1:40 PM

[2d278f]: Merge branch 'bug-18883-Clang360CompatibilityFix'

Merged commits:

2015-05-18 15:49:34 Christoph Kolb [f14d4d]
Remove unused typedefs to prevent warning in clang 3.6

• fetzer added a subscriber: • fetzer.Jun 3 2015, 2:51 PM

This bug could not be fixed during the 2015.05 release.
Setting target_milestone to AfterNextRelease

• kolbch added a comment.Jun 3 2015, 4:42 PM

there was no warning. I did something wrong but the fix was committed anyway because it was only code cleaning

kislinsk edited projects, added MITK (2016-11); removed MITK.Aug 1 2016, 10:49 PM
kislinsk changed the task status from Invalid to Spite.Jun 27 2018, 1:29 PM
kislinsk added a project: Bulk Edit.
kislinsk changed the task status from Spite to Invalid.Jun 27 2018, 1:36 PM
kislinsk removed a project: Bulk Edit.
kislinsk mentioned this in T27033: Clean up stale remote branches.Jan 25 2020, 9:01 PM
MITK · MIC · IMSY · DKFZ