Page MenuHomePhabricator

Wrong C++ 11 nullptr replacement
Closed, ResolvedPublic

Description

In berryQtControlWidget

QtControlWidget(QWidget* parent, Shell* shell, Qt::WindowFlags f = nullptr);

should be

QtControlWidget(QWidget* parent, Shell* shell, Qt::WindowFlags f = 0);

Event Timeline

User fetzer has pushed new remote branch:

bug-19103-wrong-c++11-nullptr-replacement

[e5d189]: Merge branch 'bug-19103-wrong-cpp11-nullptr-replacement'

Merged commits:

2015-05-28 14:07:14 Andreas Fetzer [2eee5b]
Replaced nullptr with 0 again

User fetzer has pushed new remote branch:

bug-19103-wrong-cpp11-nullptr-replacement

The latter branch is the right one. "++" in branch name is prevented by the git hooks