Page MenuHomePhabricator

Allow VTK Polydata to be written as binary
Closed, ResolvedPublic

Description

It was requested to add write-support for binary vtk polydata.

Event Timeline

User maerz has pushed new remote branch:

bug-19178-AllowVTKPolydataToBeWrittenAsBinary

Solution was much easier than I expected since the vtk writers are not wrapped automatically. I added vtk binary support to the legacy vtk writer. Changes only affect usage of the vtk writers, I don't believe a core change request is necessary for this one.

How did you test your changes and which parts of the Core did you change and why? :)

Changes are not tested, as I would basically retest vtk code only. inside MITK, only the necessary option was added. Options are tested inside IO framework. If you review the changes to the branch, the extend of the commit is minimal. Do you believe tests would be necessary in this case anyway? In this case I would propose to systematically test VTK IO in a seperate bug instead.

[e3efb2]: Merge branch 'bug-19178-AllowVTKPolydataToBeWrittenAsBinary'

Merged commits:

2015-07-15 16:09:47 Keno März [a515bb]
Added same functionality to vtk images, plus changed the default back to ASCII


2015-07-15 15:40:39 Keno März [175b47]
made the reader aware of potentially nonstandard vtk files

In this case, partially supported is return. This does not currently change anything in our workflows, but allows supercession of the reader by return "supported" on files with a specific header


2015-07-15 14:29:30 Keno März [18000a]
Binary data support for vtk writer

[5be7ea]: Merge branch 'bug-19178-AllowVTKPolydataToBeWrittenAsBinary'

Merged commits:

2015-09-16 17:27:42 Keno März [4b1316]
COMP: Fixed bad stringcomparison