Page MenuHomePhabricator
Create Task
Maniphest T19208

Serialize GeometryData objects with SceneIO
Closed, ResolvedPublic
Actions

Description

In the scope of a project, I would like to enhance MITK to

  • use SceneIO to save/restore instances of GeometryData
    • actually I use GeometryData to store simple offset/matrix transforms

Detailed description will be put into a core change request.

Main points:

  • would like to provide new Reader/Writer classes for the new I/O interfaces
  • would like to add a GeometryDataSerializer class to SceneSerialization.

Local proof-of-concept is written and working. I'll re-package the code properly to publish it for review and comments here.

Looking forward to comments -- please pardon any conceptual flaws, my last MITK commit has been a while ago.

Related Objects
Search...

Event Timeline

maleike added projects: MITK, Bugzilla.Aug 4 2015, 11:46 AM
maleike added a subscriber: maleike.Aug 4 2015, 8:06 PM

Initial version for comments is here:

https://github.com/maleike/MITK/compare/master...maleike:bug-19208-geometrydata-sceneio

• git-user added a subscriber: • git-user.Aug 7 2015, 5:02 PM

User maleike has pushed new remote branch:

bug-19208-geometrydata-sceneio-hook-safe
maleike added a comment.Aug 17 2015, 11:23 AM

See also T16115 where the Geometry3D to XML part has been reused and refactored into a class of its own.

maleike added a comment.Aug 25 2015, 3:50 PM

(In reply to Daniel Maleike from comment #3)

See also T16115 where the Geometry3D to XML part has been reused and
refactored into a class of its own.

I just updated the branch to use mitk::Geometry3DToXML (which is by now integrated in master).

maleike added a comment.Sep 16 2015, 9:12 AM

[700a9e]: Merge branch 'bug-19208-geometrydata-sceneio-hook-safe'

Merged commits:

2015-08-25 15:43:51 Daniel Maleike [7f9ed8]
Replace a lot of code by using class Geometry3DToXML

2015-08-25 15:23:29 Daniel Maleike [d533d0]
Merge branch 'bug-16115-store-geometry-in-pointset-file' into bug-19208-geometrydata-sceneio-hook-safe

2015-08-07 16:36:55 Daniel Maleike [0576d2]
Minimize reader and writer, do not store redundant information

Conflicts:
Modules/Core/src/IO/mitkGeometryDataWriterService.cpp

2015-08-07 16:36:24 Daniel Maleike [71abf3]
Complete test to verify all aspects of Geometry3D

2015-08-07 16:35:22 Daniel Maleike [9f9748]
Include FrameOfReference in Equal() test as any other member

2015-08-07 11:34:03 Daniel Maleike [60d7b3]
Add basic test structure, move MIME type declaration to IOMimeTypes
(move to IOMimeTypes was needed to have access to the mime type in
the new test -- the reader is not exported)

2015-08-04 17:29:29 Daniel Maleike [8f7c8b]
Initial versions of GeometryDataReader/WriterService + Serializer

maleike added a comment.Sep 16 2015, 9:39 AM

[bf11fa]: Merge branch 'bug-19208-geometrydata-sceneio-hook-safe'

Merged commits:

2015-09-16 09:36:11 Daniel Maleike [217bc3]
COMP: fix warning

maleike added a comment.Oct 7 2015, 3:03 PM

[86c97d]: Merge branch 'bug-19208-geometrydata-sceneio-hook-safe'

Merged commits:

2015-09-25 09:02:03 iwegner [88d2d7]
Also print out the exception message

2015-09-24 17:29:32 iwegner [f18647]
adding warning in case the returned geometry is not a Geometry3D in GeometryDataWriterService

MITK · MIC · IMSY · DKFZ