I experience a crash upon simply opening and closing my application.
The crash occurs in berryWorkbenchSourceProvider.cpp at line 596.
Seems like the actual window has been already destroyed and focus changes to the log window, thus the crash.
I think that similarly to the lastActiveWorkbenchWindow, lastActiveShell and lastActiveWorkbenchWindowShell should be also WeakPointers.
Description
Description
Event Timeline
Comment Actions
I honestly am not sure what is going on so deep in blueberry, but seemingly fixing the first problem unveiled another one. The second patch fixes that one.
All best,
Rostislav.
Comment Actions
Hm, I can not reproduce the crash, but it does not crash now either. As the fix seems reasonable I will merge it. Please let us know whether your problem disappears.
Comment Actions
[8fe330]: Merge branch 'bug-19268-workbench-crash-on-close'
Merged commits:
2015-08-25 21:24:48 Rostislav Khlebnikov [71c34b]
Fixed a dangling pointer
2015-08-25 17:45:51 Rostislav Khlebnikov [4047f3]
Fixed a crash on exit
Comment Actions
Yeah, my problem disappeared with those fixes. And I also found it strange that MitkWorkbench itself is working fine. Furthermore if, for example, I loaded a project and then closed it - no crash happened upon closing my app. But as you said, the fix is simple and reasonable, so big thanks for merging it in (one less difference for my MITK fork :)).