Page MenuHomePhabricator

Missing documentation and comments in mitkplanegeometry
Closed, ResolvedPublic

Event Timeline

Missing documentation and comments in mitkplanegeometry.cpp and unclear code.

May be related to bugs #11477,#18662, trouble with reinit vs. global reinit etc..

User hettich has pushed new remote branch:

bug-19381-augment-documentation-of-mitkPlaneGeometry

User hettich has pushed new remote branch:

bug-19381-add-comments-mitkPlaneGeometry-integration

A few typos:

mitkPlaneGeometry.h

"an from left" => "and from left"

This sentence is hard to understand anyway. Please split into shorter sentences. Also we should not "guess" here. ;-)

mitkPlaneGeometry.cpp

"And we scroll along each axis in this cases." => "And we scroll along each axis in these cases."

Please fix the issues above before you merge, thank you! :)

User hettich has pushed new remote branch:

bug-19381-add-comments-to-mitkPlaneGeometry-integration

User hettich has pushed new remote branch:

bug-19381-add-comments-to-mitkPlaneGeometry-initializeStandardPlane

[c37e05]: Merge branch 'bug-19381-add-comments-to-mitkPlaneGeometry-initializeSt

Merged commits:

2015-10-26 15:57:12 Martin Hettich [152846]
correct indentation and spelling.


2015-10-23 14:08:45 Martin Hettich [c03a02]
extend and amend comments for clarification in mitkPlaneGeometry

mitk::PlaneGeometry::InitializeStandardPlane() unraveled and explained,
to the best of our current understanding of mitk core code.