Page MenuHomePhabricator
Create Task
Maniphest T19428

Plugin org.mitk.gui.qt.dicom should use DICOMReader module
Closed, ResolvedPublic
Actions

Description

Replace the currently used old DICOMSeriesReader in org.mitk.gui.qt.dicom and use the infrastructure given by the DICOMReader module.

I would propose to directly switch in this plugin and not over old and new as optoin (like we do currently (T18289) in the general loading mechanism of the workbench. Reason: the potential changes in behaviour are small and as far as I know the plugin is only rarely used currently. So when deciding between usablility (no extra selction in an option box) and definsive mirgration strategy, i would opt for the first one.

Related Objects
Search...

Event Timeline

floca added projects: MITK, Bugzilla.Nov 6 2015, 9:50 AM
• git-user added a subscriber: • git-user.Mar 4 2016, 9:41 AM

User floca has pushed new remote branch:

bug-19428-dicom_plugin_should_use_DICOMReader_module
• git-user added a comment.Mar 4 2016, 9:47 AM

User floca has pushed new remote branch:

bug-19428-integration_branch
• goch added a subscriber: • goch.Mar 21 2016, 5:05 PM

Looks good so far.

I would prefer if the node name construction was moved to its own function, mostly due to T19477 and T19460. But this can be done in the appropriate bugs and does not need to be considered for this fix.

floca added a subscriber: floca.Mar 22 2016, 1:25 PM

[ea2ed6]: Merge branch 'bug-19428-integration_branch'

Merged commits:

2016-03-22 11:51:10 Ralf Floca [682eec]
fixed copy and past bug

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

2016-03-09 00:11:54 Ralf Floca [63f9eb]
added Philips3D US handling to DICOMEditor plugin and new DICOM services. (The old DICOMSeriesReader service can be set to deprecated now, because all features are covered now).

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

2016-03-04 09:32:59 Ralf Floca [d187d7]
fixed T19428

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

floca added a comment.Mar 22 2016, 1:40 PM

Regarding Comment #3: I agree. I have spared this part of refactoring but it should be done in context of the two named bugs 19477 and 19460.

kislinsk edited projects, added MITK (2016-03); removed MITK.Aug 1 2016, 10:49 PM
kislinsk mentioned this in T27033: Clean up stale remote branches.Jan 25 2020, 9:01 PM
MITK · MIC · IMSY · DKFZ