Status | Assigned | Task | ||
---|---|---|---|---|
Resolved | kislinsk | T19544 Upgrade external dependencies | ||
Resolved | None | T19549 Support Qt 5.6 (QtWebEngine instead of QtWebKit) |
Event Timeline
Increased importance as Qt < 5.6 has a bug on some Linux configurations regarding missing mouse event compression.
For Qt 5.6 we also need to upgrade VTK to version 7. Hence I merged T19548 into bug-19549-Qt56-2. Installation of VTK 7 does work in Debug configuration now. Also added a patch for CTK to make it compatible to Qt 5.6.
Please use bug-19549-Qt56-3 from now on. WebEngine migration is still work in progress. Everything should compile already, though.
linkClicked isn't a signal anymore. We need to find another way to connect DelegateMeTo again. Solution hint in the migration guide (https://wiki.qt.io/Porting_from_QtWebKit_to_QtWebEngine):
QWebPage::setLinkDelegationPolicy
There is no way to connect a signal to run C++ code when a link is
clicked. However, link clicks can be delegated to the Qt application
instead of having the HTML handler engine process them by overloading
the QWebEnginePage::acceptNavigationRequest() function. This is
necessary when an HTML document is used as part of the user interface,
and not to display external data, for example, when displaying a
list of results.
Overriding acceptNavigationRequest() doesn't work for URLs with qthelp scheme. There's another approach based on QWebEngineUrlSchemeHandler:
https://codereview.qt-project.org/#/c/126715/2/src/assistant/assistant/helpbrowsersupport.cpp
Okay, qthelp pages work again.
TODOs:
- Crash on Workbench close when help is/was opened
- d3 based histogram in measurement toolbox.
We should consider merging bug-19549-Qt56-3 as soon as the dashboard is green again. The d3 histogram is suitable for a separate bug. The crash should be fixed before merging, though.
[7bc132]: Merge branch 'bug-19549-Qt56-3'
Merged commits:
2016-04-30 16:28:29 Stefan Kislinskiy [5ac5b8]
COMP: Require Qt 5.6 with QWebEngineWidgets
Disable MSVC 2015 warnings
Fix invalid implicit cast
Replace WebKit with WebEngine (WIP)
Fix linking to external urls and mitk scheme urls
Remove print functionality from help editor
Implemented qthelp url scheme handler
Fix crash on application shutdown when help is or was opened