Page MenuHomePhabricator
Create Task
Maniphest T22152

Input fields with unit 'number' in Decision Making accept decimal input
Open, NormalPublic
Actions

Description

Steps to reproduce:

  • Run API server with option -d
  • Run dashboard
  • Select DemoPatient
  • Switch to Decision Making view
  • Select node 'Ultrasound examination' -Type a decimal value in field 'Number of Tumors' -Press key 'enter'

The tooltip 'Please select a valid number' appears, but the system accepts the input. If you reload the view, the input of the decimal value is still in the box.

Event Timeline

• klinowsk created this task.Nov 22 2016, 1:16 PM
• klinowsk claimed this task.Dec 6 2016, 11:10 AM
• klinowsk moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• klinowsk moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
maerz added a subscriber: maerz.Jan 19 2017, 3:09 PM

I don't think that we currently model floating point vs integer restrictions at all. It would be very sensible to type check these, but it is probably not a completely simple task.

• klinowsk added a comment.Jan 19 2017, 3:40 PM

I added a simple regular expression check in merge b206ce8bf152 . Fields with a number label "#" should now only accept integers and decimals with .0 (1.0, 2.0 etc.). Every other label should accept all floating point input.

maerz added a comment.Jan 23 2017, 1:06 PM

Could you perform a quick feasibility test on the ontology? Just to make sure that this doesn't have side-effects that we are unaware of.

• klinowsk added a comment.Jan 23 2017, 1:23 PM

It could make some problems with qualities that are not used in the decision tree at the moment (it would have been the same problem with the regular expression that was used before).
Some of them have unit:number as the preferred unitlabel, but are not "number qualities".
I can change the regular expression back to accepting everything. Or maybe we should change the unitlabel of these qualties to "freetext" or something more fitting than number?

MITK · MIC · IMSY · DKFZ