Page MenuHomePhabricator

Bin size handling in QmitkImageStatisticsCalculationThread
Closed, WontfixPublic

Description

We have the following functions:

void SetUseDefaultNBins(bool useDefault);
void SetHistogramBinSize( double size);
void SetHistogramNBins( double size);

But the handling of the bin size and nbins is obscure:

if (m_UseDefaultNBins)
  {
      calculator->SetNBinsForHistogramStatistics(100);
  }
  else
  {
      if (!m_prioritizeNBinsOverBinSize)
      {
          calculator->SetBinSizeForHistogramStatistics(m_HistogramBinSize);
      }
      else
      {
          calculator->SetNBinsForHistogramStatistics(100);
      }
  }

Implement it in a clear way!!

This possibly leads to erroneous calculations in the ImageStatisticsCalculator plugin.

Event Timeline

kislinsk claimed this task.
kislinsk added a project: Auto-closed.
kislinsk added a subscriber: kislinsk.

Hi there! 🙂

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. 🚑

Best wishes,
The MITK devs

kislinsk removed kislinsk as the assignee of this task.May 26 2020, 12:05 PM
kislinsk removed a subscriber: kislinsk.