Page MenuHomePhabricator
Create Task
Maniphest T23055

Debug build problem in itkStreamlineTrackingFilter
Closed, ResolvedPublic
Actions

Description

When compiling in Debug in Visual Studio 2015 the compilation fails in line 112 of itkStreamlineTrackingFilter.h. This is the following line:

itkSetMacro( SeedPoints, std::vector< itk::Point<float> >)

In Debug itkSetMacro tries to print a message using itkDebugMacro. It streams the std::vector to a std::ostringstream. In this context there is no overloaded << operator for std::ostream, so it does not compile. I think the best solution is to write a setter for that vector manually, not using the itk macro.

Related Objects

Event Timeline

milano created this task.Jul 7 2017, 3:44 PM
milano updated the task description. (Show Details)Jul 7 2017, 11:06 PM
kislinsk triaged this task as Normal priority.Jul 11 2017, 10:40 AM
kislinsk added a project: Pull Request.
kislinsk added subscribers: neher, kislinsk.

@neher
https://github.com/MITK/MITK/pull/205

neher added a comment.Jul 11 2017, 11:00 AM

Hi @milano ,

thank you for your contribution. Before merging your pull request we need you to sign off you commits: http://mitk.org/wiki/Sign_off_contribution

Cheers,
Peter

milano added a comment.Jul 12 2017, 3:05 PM

Hello Peter,

I have just generated a new commit signing that pull request. The only issue is that by amending my previous comment I had to sync with the commits in the master repository, so those commits are part of the pull request. Do you want me to create a whole new pull request or you can just merge my latest commit and discard the rest?

Thank you,

Fede

kislinsk added a comment.Jul 12 2017, 3:11 PM

Hi, please create a new pull request and open a new branch for it in your repo instead of working on your master branch. This is the most easy way for us to merge your contribution. Thank you!

milano added a comment.Jul 12 2017, 4:04 PM

Ok, I have created a new pull request:

https://github.com/MITK/MITK/pull/206

Thank you!

Fede

neher added a comment.Jul 13 2017, 10:11 AM

Pushed new branch T23055-StdVectorInSetMacro.

milano mentioned this in rMITKd5392981fef8: T23055 fixes the itkSetMacro for std::vector parameter Signed-off-by: Federico….Jul 13 2017, 10:11 AM
neher mentioned this in rMITK4f5cc16acb5f: Merge remote-tracking branch 'MITK-fmilano/T23055-StdVectorInSetMacro' into….Jul 13 2017, 10:11 AM
neher mentioned this in rMITKdf29f68ea487: Merge branch 'T23055-StdVectorInSetMacro'.
neher closed this task as Resolved.Sep 3 2018, 1:01 PM
neher claimed this task.
MITK · MIC · IMSY · DKFZ