Page MenuHomePhabricator

Calling SwapPointPosition in PointSet deletes one of the points
Closed, ResolvedPublic

Description

Swaping a point upwards removes the former point on the position.
Swaping a point downwards removes the next point on the position.

To fix, we have to keep the former/next point and write it back. If swap is not possible (former/next index does not exist) the method should do nothing and return false.

Related Objects

StatusAssignedTask
ResolvedNone

Event Timeline

adding missing changeRequest

I understand that you want to enhance PointSetTest to check correct swapping, right? (because right now the test does not test much)

Revision 18547:
Corrected implementation. Both points are swapped now, if swapping is not possible the method returns false.

kislinsk reopened subtask Restricted Maniphest Task as Open.Jun 27 2018, 3:03 PM
kislinsk closed subtask Restricted Maniphest Task as Resolved.Jun 27 2018, 3:29 PM