Page MenuHomePhabricator
Create Task
Maniphest T24265

MITK Extension mechanism: how to change settings in required third party projects.
Closed, WontfixPublic
Actions

Description

Problem: Currently we have no means the define in a third party project settings that have implication on other required third party projects.

Example:
A third party project A that needs Boost libraries, can specify boost as a dependency. But it is currently not able to alter "MITK_USE_Boost_LIBRARIES" to set the needed libs.

Reason:
The CMake files of required third party projects (e.g.) is evaluated befor the other projects. Thus the external project boost is already configured and set if an depending project A asks for special libs.

One could think about different mechanisms to solve that. Would be good if we could discuss that topic and came up with a favored way.
Its no showstopper. It makes the build instructions currently a bit more complex.

Event Timeline

floca created this task.Feb 14 2018, 2:51 PM
kislinsk triaged this task as Low priority.Apr 11 2018, 2:07 PM
kislinsk added a subscriber: kislinsk.

I think Eric did this with Boost in his external project. I didn't check but I advised him to add a third party project to his CMakeExternal folder that does nothing but add libraries to MITK_USE_Boost_LIBRARIES.

floca renamed this task from MITK Extension mechanism: who to change settings in required third party projects. to MITK Extension mechanism: how to change settings in required third party projects..Apr 11 2018, 2:22 PM
floca updated the task description. (Show Details)
floca added a comment.Apr 11 2018, 2:28 PM
In T24265#128413, @kislinsk wrote:

I think Eric did this with Boost in his external project. I didn't check but I advised him to add a third party project to his CMakeExternal folder that does nothing but add libraries to MITK_USE_Boost_LIBRARIES.

Using this approach (nice idea), how do you ensure that this special settings are evaluated before Boost.cmake is processed and the external project for boost is configured?

kislinsk added a comment.EditedApr 12 2018, 1:10 PM

Isn't this guaranteed as all projects are generated during the "Generate" step so it doesn't really matter if Boost.cmake is processed in the configure phase before or after the other external project? - Not sure, would have to check...

floca added a comment.Apr 16 2018, 10:34 AM
In T24265#128547, @kislinsk wrote:

Isn't this guaranteed as all projects are generated during the "Generate" step so it doesn't really matter if Boost.cmake is processed in the configure phase before or after the other external project? - Not sure, would have to check...

Yes, this has to be verified.

I always thought (but this isn't based on first hand experience/facts), that calling ExternalProjects_Add directly configures the target and copies the passed settings. If this is the case, boost will be only reflect other EP settings if these EPs are evaluated before boost in SuperBuild.cmake line 216ff.

kislinsk closed this task as Wontfix.May 26 2020, 11:17 AM
kislinsk claimed this task.
kislinsk added a project: Auto-closed.

Hi there! 🙂

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. 🚑

Best wishes,
The MITK devs

kislinsk removed kislinsk as the assignee of this task.May 26 2020, 12:05 PM
kislinsk removed a subscriber: kislinsk.
floca reopened this task as Open.May 26 2020, 1:12 PM
floca removed a project: Auto-closed.
kislinsk added a comment.May 27 2020, 1:45 PM

FYI, there's also https://github.com/MITK/MITK-ProjectTemplate/blob/master/CMakeExternals/Customization/ITK.cmake.

kislinsk closed this task as Wontfix.Sep 9 2022, 10:22 AM
kislinsk added a project: Auto-closed.

Hi there! 🙂

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. 🚑

Best wishes,
The MITK devs

MITK · MIC · IMSY · DKFZ