Page MenuHomePhabricator

Remove unused global variables from mitkSlicedGeometry3D
Closed, WontfixPublic

Description

There are three static strings in the interface of mitkSlicedGeometry3D :

static const std::string SLICES;
const static std::string DIRECTION_VECTOR;
const static std::string EVENLY_SPACED;

These variables are never set, and a search in the MITK source trees shows no usage of these variables. Additionally, they don't seem to have any purpose.

I found these code while creating a SWIG-based wrapping as they cause a linker error. I found out this is because they are never initialized. Therefore, i suggest to remove them.

Revisions and Commits

Event Timeline

goetzm triaged this task as Normal priority.Mar 27 2018, 5:42 PM
goetzm created this task.
goetzm added a revision: Restricted Differential Revision.Mar 27 2018, 5:47 PM
kislinsk removed goetzm as the assignee of this task.
kislinsk added a project: Auto-closed.
kislinsk added a subscriber: kislinsk.

Hi there! ๐Ÿ™‚

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. ๐Ÿš‘

Best wishes,
The MITK devs