Page MenuHomePhabricator
Create Task
Maniphest T25171

Workbench crashes when accessing the "Hotkeys"-Preference page for the data manager (only debug)
Closed, ResolvedPublic
Actions

Description

To reproduce:

  1. Start MITK in debug-mode
  2. Press Ctrl+P or go to "Window -> Preference" to open the preference menu
  3. click on "DataManager -> Hotkeys"
  4. Experience a workbench crash in mitkBaseApplication. Output is:
259.56 core.mod.apputil.baseApp ERROR: ASSERT: "uint(i) < uint(size())" in file c:\users\qt\work\qt\qtbase\src\corelib\tools\qstring.h, line 1544

Related Objects

Event Timeline

kalali triaged this task as Normal priority.Aug 1 2018, 12:03 PM
kalali created this task.
kalali added a comment.Aug 17 2018, 11:29 AM

The error seems to be in the QKeySequence.
Looks like Qt cannot handle the Ctrl+ sequence. Why is this only happening in debug mode?

However, even in release mode the Ctrl+-sequences do not work (e.g. try Ctrl+R for GlobalReinit).

kalali added a comment.Aug 17 2018, 1:43 PM

The preference page does not show the Ctrl+-part of the sequence, but starts with a comma (e.g. , R). If the user changes a key sequence to a combination of Ctrl+letter, the sequence is recognized and shown as text in the line edit. If the user clicks on Ok and reopens the preference page, the Ctrl+-part is removed and the sequence starts with a comma again.

kalali added a comment.EditedAug 17 2018, 5:17 PM

Apparently initializing a QKeySequence with QKeySequence(keyEvent->modifiers(), keyEvent->key()) does not work, since both arguments will be taken as individual integers, each representing a key. The first argument however is only a modifier and does not represent a real key - it can only be combined with a key. That's why the result is , Key, where the first key is not recognized.
Using QKeySequence(keyEvent->modifiers() + keyEvent->key()) solved this problem.

kalali added a comment.Aug 17 2018, 5:23 PM

Pushed new branch T25171-Hotkeys-preference-page-crash.

kalali claimed this task.Nov 29 2018, 4:28 PM
kalali closed this task as Resolved.Nov 29 2018, 4:52 PM

Contained in T25056

kalali mentioned this in rMITK7836da9ac4ff: Merge remote-tracking branch 'origin/T25171-Hotkeys-preference-page-crash' into….Nov 29 2018, 4:56 PM
MITK · MIC · IMSY · DKFZ