Page MenuHomePhabricator

ThemeIcon() of QmitkStyleManager and berryQtStyleManager does not work with eager plugins
Closed, ResolvedPublic

Description

If one tries to theme icon in the activator of an eager plugin (e.g. org.mitk.gui.qt.matchpoint.core.helper), it does not work and the icon does not get themed.

Reason: Eager plugin activatores are activated before berryQtWorkbenchAdvisor::Initialize() is called. In this initialize() call the the style name is recived from the app preferences and SetStyle() of the style manager is called. At this point the style sheet is available. Before that the default style sheets have been added to the berryQtStyleManager, but none has been selected. So ThemeIcon() gets an empty style sheet and leaves the icon untouched.

Revisions and Commits

rMITK MITK
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

kislinsk triaged this task as Normal priority.Nov 22 2018, 2:17 PM
kislinsk added a project: Auto-closed.
kislinsk added a subscriber: kislinsk.

Hi there! ๐Ÿ™‚

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. ๐Ÿš‘

Best wishes,
The MITK devs

floca removed a project: Auto-closed.
kislinsk added a revision: Restricted Differential Revision.Mar 21 2023, 1:24 PM

Deleted branch from rMITK MITK: bugfix/T25316-EnableThemedIconsInEagerPlugins.