Page MenuHomePhabricator
Create Task
Maniphest T25424

Since cmake 3.12 FindPythonLibs is deprecated
Closed, ResolvedPublic
Actions

Description

MITK requires python 3, so we should use the new FindPython3:
https://cmake.org/cmake/help/v3.12/module/FindPython3.html#module:FindPython3

Also, FindPython3 should probably be called in the associated Config.cmake
Why currently in top level CmakeLists.txt and also other places associated with the new MITK python wrapping? And why is the config file called MITK_PythonLibs_Config.cmake and now, corresponding to the variable MITK_Python_Config.cmake?

Required cmake version will be upgraded to 3.12 in T25420

Revisions and Commits

Restricted Differential Revision

Related Objects

Event Timeline

neher created this task.Sep 10 2018, 2:41 PM
kislinsk triaged this task as Wishlist priority.Nov 22 2018, 2:20 PM
neher claimed this task.Dec 11 2018, 5:08 PM
neher added a comment.Dec 11 2018, 5:16 PM

Pushed new branch T25424-FindPython3.

neher added a comment.Dec 12 2018, 11:55 AM

If python3 is NOT found, the executable cannot be specified manually since the corresponding cache variable seems to be deleted every time find_package(Python3) is called. Cmake bug?

neher added a comment.Jul 2 2019, 11:31 AM

Pushed new branch T25424-FindPython3New.

neher added a revision: Restricted Differential Revision.Jul 4 2019, 7:24 AM
neher mentioned this in rMITKdb2f41beadc2: Switch to new FindPython3 cmake command.Jul 4 2019, 10:57 AM
neher closed this task as Resolved.Jul 5 2019, 8:29 AM
kislinsk mentioned this in T27033: Clean up stale remote branches.Jan 25 2020, 9:00 PM
MITK · MIC · IMSY · DKFZ