Page MenuHomePhabricator

"Show in" action is currently not implemented
Closed, ResolvedPublic

Description

The "Show in" action, which allows to to open a new editor, is currently not implemented.

Edit:
This context menu entry will be refactored according to the new multi widget editor.
The action will be completely removed from the code base since we don't consider this a relevant feature.

Revisions and Commits

rMITK MITK
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

kalali triaged this task as Normal priority.Dec 5 2018, 4:22 PM
kalali created this task.
kalali added a project: Restricted Project.Oct 4 2019, 10:21 AM
kislinsk added a subscriber: kislinsk.

Hi there! 🙂

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. 🚑

Best wishes,
The MITK devs

kalali edited projects, added MITK (v2022.10); removed Restricted Project, MITK.
kalali moved this task from Backlog to mxn MultiWidget on the MITK (v2022.10) board.
kalali added a revision: Restricted Differential Revision.May 31 2022, 8:13 PM

@floca Did you test the differential in the Workbench? Actually I was just implementing this feature witch was there for many years but never functioning. It was never of any use since we only had a single rendering display. What I realized, though: the use is barely existing, since you can only "send" a node to a render display / multi widget. But the StdMultiWidget displays the nodes anyway and the mxnMultiWidget should be controllered differently, right (since you only send the node to the whole multi widget, not to a single render window)?
So I can land the changes but I'm also fine with removing the feature entirely, eventually.

@floca Did you test the differential in the Workbench? Actually I was just implementing this feature witch was there for many years but never functioning. It was never of any use since we only had a single rendering display. What I realized, though: the use is barely existing, since you can only "send" a node to a render display / multi widget. But the StdMultiWidget displays the nodes anyway and the mxnMultiWidget should be controllered differently, right (since you only send the node to the whole multi widget, not to a single render window)?
So I can land the changes but I'm also fine with removing the feature entirely, eventually.

I must admit I only did a static code review. I also thought that the relevance is given because you needed for mxn somehow. as it was broken all these years and nobody complained, I see no problem in completely removing it as a feature. maybe that's even better to reduce code base, but I have no strong opinion.
@kislinsk you?

I must admit I only did a static code review. I also thought that the relevance is given because you needed for mxn somehow. as it was broken all these years and nobody complained, I see no problem in completely removing it as a feature. maybe that's even better to reduce code base, but I have no strong opinion.
@kislinsk you?

We decided to remove the feature and reduce the code base. We can add this again if we deem this useful in the future.