Page MenuHomePhabricator
Create Task
Maniphest T26160

[PR232] Tiny refactoring of BoundingShapeVtkMapper2d
Closed, ResolvedPublic
Actions

Description

Fixes flickering behavior of Image Cropper on most MR images for example.

Previous version was flickering a lot unless the bbox was world axes aligned.

For debugging I renamed some variables from a/b/c/result_x to something more expressive and improved one calculation. Now it is less sensitive when a cube is not perfectly world-axes aligned.

Could be integrated into release branch and master.

Related Objects

Event Timeline

maleike created this task.Mar 13 2019, 12:36 PM
kislinsk edited projects, added MITK; removed MITK (2018-04-2).Mar 13 2019, 4:00 PM
kislinsk added a subscriber: kislinsk.

Sorry, this was too close to the MITK 2018.04.2 release to be considered to be part of the bugfix release.

kislinsk edited projects, added MITK (2018-04-4); removed MITK.Mar 29 2019, 8:39 AM
kislinsk renamed this task from Github pull request 232 (Tiny refactoring of mitkBoundingShapeVtkMapper2d.cpp) to [PR232] Tiny refactoring of BoundingShapeVtkMapper2d.Mar 29 2019, 2:02 PM
kislinsk claimed this task.
kislinsk triaged this task as Normal priority.
kislinsk added a comment.Mar 29 2019, 2:05 PM

Pushed new branch T26160-PR232.

kislinsk mentioned this in rMITKa86cd2ca258a: Merge remote-tracking branch 'maleike/tiny-refactor-bbox-rendering2d' into….Mar 29 2019, 2:05 PM
kislinsk mentioned this in rMITK9bbd9e6e5b1f: Merge branch 'T26160-PR232' into releases/2018-04.Mar 29 2019, 2:08 PM
kislinsk closed this task as Resolved.Mar 29 2019, 2:10 PM
kislinsk edited projects, added MITK; removed MITK (2018-04-4).Feb 11 2020, 4:42 PM
MITK · MIC · IMSY · DKFZ