Page MenuHomePhabricator

Patching on windows fails
Open, NormalPublic


Apparently not on all Windows systems.
Exemplary error message (assertion error for all patches):

Assertion failed: hunk, file ../patch-2.5.9-src/patch.c, line 354

Works fine if the --binary option is used

Event Timeline

neher triaged this task as Normal priority.Jul 13 2019, 11:55 AM
neher created this task.
neher removed neher as the assignee of this task.Dec 2 2019, 3:42 PM

This happens on Windows systems with the wrong checkout type for line endings. So not really a bug. We should investigate if the binary option is worth it anyway, as it is currently a big hassle to get patches right in the first place on Windows.