Page MenuHomePhabricator
Create Task
Maniphest T26501

Patching on windows fails
Closed, WontfixPublic
Actions

Description

Apparently not on all Windows systems.
Exemplary error message (assertion error for all patches):

Assertion failed: hunk, file ../patch-2.5.9-src/patch.c, line 354

Works fine if the --binary option is used

Related Objects

Event Timeline

neher triaged this task as Normal priority.Jul 13 2019, 11:55 AM
neher created this task.
neher added a comment.Jul 13 2019, 11:56 AM

Pushed new branch T26501-WinPatchBinary.

neher removed neher as the assignee of this task.Dec 2 2019, 3:42 PM
kislinsk added a comment.Dec 4 2019, 11:38 PM

This happens on Windows systems with the wrong checkout type for line endings. So not really a bug. We should investigate if the binary option is worth it anyway, as it is currently a big hassle to get patches right in the first place on Windows.

kislinsk mentioned this in T27033: Clean up stale remote branches.Jan 25 2020, 9:00 PM
kislinsk closed this task as Wontfix.Apr 29 2022, 1:43 PM
kislinsk added a project: Auto-closed.

Hi there! 🙂

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. 🚑

Best wishes,
The MITK devs

MITK · MIC · IMSY · DKFZ