Page MenuHomePhabricator

Review checklists
Open, LowPublic

Description

I was looking through some checklists and spotted several errors. I will list them here and people can add things they stumbled upon.

I used the checklists from E130-Daten\Release\Checklisten\MITK Workbench Release.

Checklists

  1. Checklist Applikationsrahmen
    • Test 2: Datei ''test_surface.stl'' laden ->File reading options dialog wird angezeigt Datei wird in Mitk geladen und Surface wird angezeigt
      • -> Neuer(?) Ladedialog, der Optionen zum Laden abfragt
    • Test 6: Auf Segmentierung im Multiwidget klicken -> Crosshair wird an die geklickte Stelle verschoben. In der StatusBar erscheint ein Text mit der Position des Crosshairs und der Pixelinformation dieser Position. Diese darf keine Binärinformation sein (1 oder 255)
      • -> Wenn die Segmentierung sichtbar ist (also über dem Pic3D liegt) wird auch die Binärinformation der Segmentierung angezeigt, und nicht erst, wenn das Originalbild versteckt wird.

        Discussion: How should we handle those pixel values? Currenlty it shows the pixel values of the segmentation. --> Might be solved / changed / handled with T25043
    • PACS mode is not tested --> outdated? Still necessary/valid? (mentioned in T26984)
  1. Checklist DICOM Viewer
    • Rather replace with the open source version (mentioned in T26991)
  1. Checklist ImageRendering
    • Global init / Global reinit tests not well defined
    • What do we need mini3D for?
  1. Checklist LevelWindow
    • Rather use one example image with defined values for testing or transfer to Unittest (mentioned in T26988)
  1. Checklist 3D Segmentierung
    • Data in Checklists originates from 3M3 / networkdrive / MITKData and often no Information is given (example: Thomas K mini3D) mentioned in T26989 --> should we define one accessible folder with: Demo data, GUI test data and unittest data?
  1. Checklist Manuelle Segmentierung
    • Correction Tool: Still necessary? If yes, needs fixing (Task T22391 hasn't been touched for two years)
    • Live Wire Tools: Die gelben Konturen werden weiterhin angezeigt, können aber nicht mehr bearbeitet werden
      • -> really?
  1. Checklist ViewNavigator
    • Perspectives cannot be saved
    • Default perspectives are questionable (mentioned in T26990)
  1. Checklist Installer
    • Check .exe with filname here instead of in "Applikationsrahmen"

General discussion

  • English language, storage / format for checklists: T26987
  • Automatic GUI testing - Squish for Qt
  • Discrepancy / bias from checklists: T26982
  • Logging

Event Timeline

kalali created this task.Oct 15 2019, 4:12 PM
kalali added a subscriber: thomass.
kalali updated the task description. (Show Details)Oct 15 2019, 4:46 PM
kalali updated the task description. (Show Details)Oct 18 2019, 10:43 AM
kalali triaged this task as Low priority.Oct 18 2019, 3:21 PM
kalali added a project: Restricted Project.
kalali updated the task description. (Show Details)Jan 7 2020, 2:43 PM
kalali updated the task description. (Show Details)Jan 7 2020, 5:39 PM
thomass updated the task description. (Show Details)Jan 9 2020, 1:53 PM
thomass added subscribers: gaoh, kahl.
kalali edited projects, added Restricted Project, Request for Discussion; removed Restricted Project.Jan 10 2020, 11:43 AM
thomass updated the task description. (Show Details)Jan 10 2020, 9:20 PM
kalali updated the task description. (Show Details)Jan 13 2020, 12:38 PM
floca added a parent task: Restricted Maniphest Task.Apr 26 2020, 1:49 PM
kalali updated the task description. (Show Details)Fri, Sep 11, 1:55 PM