Page MenuHomePhabricator
Create Task
Maniphest T27258

[Image statistics] Deprecate QmitkImageStatisticsCalculationJob
Closed, ResolvedPublic
Actions

Description

We have the job class based on QtThread and the QmitkImageStatisticsCalculationRunnable based on QtRunnable. Both do practically the same and are redundant.
I would deprecate the job class in favor of the runnable class.

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKd3f539e52e74 T26350 Add multi label support to statistic
Restricted Differential RevisionrMITKa84094791be0 BREAKING! Deactivate Hotspot generator
Restricted Differential RevisionrMITKa8890bead981 Fixed review remarks
Restricted Differential RevisionrMITKfaea919979f8 fixed GCC errors
Restricted Differential RevisionrMITK8ef6457b1352 Fixed the correct display of statistic elements that are WIP or N/A.
Restricted Differential RevisionrMITK48b81bb57bc2 Adapted widget text in order to make the purpose easier to grasp.
Restricted Differential RevisionrMITKfe59b6b331b6 Ensured that changing the segmentation content also triggers
Restricted Differential RevisionrMITKc951604fdac0 Fixed compiler issues
Restricted Differential RevisionrMITKbab3830e69cc Fixed crash of statstic view if a mask with only empty labels is selected.
Restricted Differential RevisionrMITKb236a2ecfa87 Added mutex to secure internal label and group maps of LabelSetImage.
Restricted Differential RevisionrMITK374d20821ecb Fixed implementation/usage of node in QmitkMultiLabelManager
Restricted Differential RevisionrMITK30c2d7bfbd7f Added modified to the mask generator to ensure correct update of the mask
Restricted Differential RevisionrMITK541bc024b09b Introduced ITKEventObserverGuards to allow the combination of
Restricted Differential RevisionrMITK6b53515806d7 BREAKING!!! MaskGenerator interface was changed.
Restricted Differential RevisionrMITK3be31e70397d Make histogram group invisible as default
Restricted Differential RevisionrMITK3866be21a224 Add mitk::WeakPointer support for const types.
Restricted Differential RevisionrMITKc70dd4ac8b48 Improved performance of statistics computation in case of many images/masks
Restricted Differential RevisionrMITKfd5dbfe4805e Fixed error in the QmitkImageStatisticView as histogram
Restricted Differential RevisionrMITK2e9914b612e8 Fixed error in FeatureBasedEdgeDetectionFilter as mask was ignored.
Restricted Differential RevisionrMITKe845d0e97b40 Added Label color decoration to label tree items
Restricted Differential RevisionrMITK59151159b8c6 Fixed crash in statistic model if "no zeros" is activated
Restricted Differential RevisionrMITK30e8658d800f Added modified to the mask generator to ensure correct update of the mask
Restricted Differential RevisionrMITKec323732ba9a Adapted Qmitk classes to statistics container rework
Restricted Differential RevisionrMITKd618575b62b5 Removed QmitkImageStatisticsCalculationJob
Restricted Differential RevisionrMITK0e5a6a4d0582 BREAKING!!! ImageStatisticsContainer does no store statistics for multiple label

Related Objects
Search...

Event Timeline

floca triaged this task as Normal priority.Mar 26 2020, 10:42 PM
floca created this task.
floca moved this task from Backlog to MITK Meeting on the Request for Discussion board.Mar 27 2020, 11:37 AM
floca removed a project: Request for Discussion.EditedMar 27 2020, 11:48 AM

OK.
Before T27134: [Image statistics] Refactor Calculation Job and Calculation Runnable has to be done.
And we remove it directly :)

floca added a subtask: T27134: [Image statistics] Refactor Calculation Job and Calculation Runnable.Mar 27 2020, 11:50 AM
kislinsk moved this task from Backlog to MaaS on the MITK (v2021.02) board.Apr 2 2020, 2:52 PM
kalali lowered the priority of this task from Normal to Low.May 6 2020, 2:29 PM
floca edited projects, added Next Milestone; removed MITK (v2021.02).Sep 10 2020, 4:26 PM
kislinsk added a project: MITK.Sep 10 2020, 5:38 PM
kislinsk edited projects, added MITK (v2022.04); removed MITK, Next Milestone.Nov 16 2021, 9:23 AM
kalali renamed this task from [statistics] Deprecate QmitkImageStatisticsGeneratorJob to [Image statistics] Deprecate QmitkImageStatisticsCalculationJob .Dec 2 2021, 1:29 PM
kalali updated the task description. (Show Details)
kalali added a subscriber: kalali.

@floca I changed the name / description since I didn't find a QmitkImageStatisticsGeneratorJob. I assumed you meant QmitkImageStatisticsCalculationJob.

kislinsk edited projects, added Next Milestone, MITK; removed MITK (v2022.04).Apr 29 2022, 1:39 PM
kislinsk edited projects, added MITK (v2023.12); removed MITK, Next Milestone.May 17 2023, 2:57 PM
kislinsk edited projects, added MITK (v2024.06); removed MITK (v2023.12).Dec 5 2023, 10:38 AM
kislinsk closed subtask T27134: [Image statistics] Refactor Calculation Job and Calculation Runnable as Wontfix.Dec 5 2023, 10:43 AM
floca claimed this task.Feb 27 2024, 10:44 AM
floca added a revision: Restricted Differential Revision.Mar 13 2024, 12:52 PM
floca closed this task as Resolved by committing rMITKd618575b62b5: Removed QmitkImageStatisticsCalculationJob.Mar 19 2024, 9:37 AM
floca added a commit: rMITK0e5a6a4d0582: BREAKING!!! ImageStatisticsContainer does no store statistics for multiple label.
floca added a commit: rMITKd618575b62b5: Removed QmitkImageStatisticsCalculationJob.
floca added a commit: rMITK30e8658d800f: Added modified to the mask generator to ensure correct update of the mask.
floca added a commit: rMITKec323732ba9a: Adapted Qmitk classes to statistics container rework.
floca added a commit: rMITK59151159b8c6: Fixed crash in statistic model if "no zeros" is activated.
floca added a commit: rMITK2e9914b612e8: Fixed error in FeatureBasedEdgeDetectionFilter as mask was ignored..
floca added a commit: rMITKfd5dbfe4805e: Fixed error in the QmitkImageStatisticView as histogram.
floca added a commit: rMITKe845d0e97b40: Added Label color decoration to label tree items.
floca added a commit: rMITK3866be21a224: Add mitk::WeakPointer support for const types..
floca added a commit: rMITKc70dd4ac8b48: Improved performance of statistics computation in case of many images/masks.
floca added a commit: rMITK3be31e70397d: Make histogram group invisible as default.
floca added a commit: rMITK6b53515806d7: BREAKING!!! MaskGenerator interface was changed..
floca added a commit: rMITK30c2d7bfbd7f: Added modified to the mask generator to ensure correct update of the mask.
floca added a commit: rMITK541bc024b09b: Introduced ITKEventObserverGuards to allow the combination of.
floca added a commit: rMITKb236a2ecfa87: Added mutex to secure internal label and group maps of LabelSetImage..
floca added a commit: rMITK374d20821ecb: Fixed implementation/usage of node in QmitkMultiLabelManager.
floca added a commit: rMITKbab3830e69cc: Fixed crash of statstic view if a mask with only empty labels is selected..
floca added a commit: rMITKfe59b6b331b6: Ensured that changing the segmentation content also triggers.
floca added a commit: rMITK48b81bb57bc2: Adapted widget text in order to make the purpose easier to grasp..
floca added a commit: rMITKc951604fdac0: Fixed compiler issues.
floca added a commit: rMITK8ef6457b1352: Fixed the correct display of statistic elements that are WIP or N/A..
floca added a commit: rMITKfaea919979f8: fixed GCC errors.
floca added a commit: rMITKa8890bead981: Fixed review remarks.
floca added a commit: rMITKa84094791be0: BREAKING! Deactivate Hotspot generator.
floca added a commit: rMITKd3f539e52e74: T26350 Add multi label support to statistic.
MITK · MIC · IMSY · DKFZ