Page MenuHomePhabricator
Create Task
Maniphest T27308

[statistics] Statistics with segmentations are not automatically updated if segmentation is changed.
Closed, ResolvedPublic
Actions

Description

In the image statistics view statistics of/with segmentations are not updated if the segmentation is changed.

Reason: Segmentation tools do modify the segmentation image, but the modification of the data does not automatically mark the node as modified. The statistics data generator does listen to node modifications and thus misses the change of the segmentations.
Planar figures have no problem as the planar figure interaction does also modify the node.

It is a question very simelar to T22322: Changing a renderer-specific property list of a data node does not modify the data node, should modifying the data always modify the node?

If yes: this task is automatically solved if the modification is correctly handled (T27307).
If no: What is the proper solution?
a) the generator should register/ observer for all data instances of nodes it should watch?
b) add the node->Modified() somewhere in the segmentation tools or views?

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITK2514ffc408de Fixed T27308
Restricted Differential RevisionrMITK2f8d7d3dd56b Fixed T27308

Related Objects

Event Timeline

floca triaged this task as High priority.Apr 12 2020, 1:26 PM
floca created this task.
floca moved this task from Backlog to MITK Meeting on the Request for Discussion board.
floca moved this task from Backlog to Segmentation on the MITK (v2021.02) board.
floca mentioned this in T27307: Modifying the data does not modify the data node.Apr 15 2020, 6:15 PM
kislinsk moved this task from Segmentation to MaaS on the MITK (v2021.02) board.Apr 16 2020, 9:19 AM
floca removed a project: Request for Discussion.Apr 24 2020, 1:21 PM

Discussion result:
For this concrete problem we will mitigate by introducing Modified() calls for the nodes in the tools, simelar to how the planarfigure nodes are modfified by the planarfigure interactor when they are changed.
A more thorough solution as discussed T27307 takes more time and is not realistic for the next release.
Depending T272ß7 it could well be that the workarround can/will be removed at a later point.

floca added a project: Cleared.May 8 2020, 10:41 AM
floca claimed this task.May 20 2020, 9:18 PM
nolden renamed this task from [statistics] Statistics with segmentations are not automatically actualized if segmentation is changed. to [statistics] Statistics with segmentations are not automatically updated if segmentation is changed..May 24 2020, 9:02 PM
floca closed this task as Resolved by committing rMITK2f8d7d3dd56b: Fixed T27308.May 26 2020, 5:45 PM
floca added a commit: rMITK2f8d7d3dd56b: Fixed T27308.
floca added a commit: rMITK2514ffc408de: Fixed T27308.
MITK · MIC · IMSY · DKFZ